Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-383: Allow user input of registration year #250

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

edmondsgarrett
Copy link
Contributor

Overview

Per UTH, now allow user to write in registration year on registration form

Related

Changes

  • Added input type=number field for Registration Year on registration form, with min value of 2023
  • On create and update registration db functions, changed value written to database for registration_year to value from form
  • Added 'Registration Year' field to view registration modal + corresponding Django context object

Testing

  1. Go to https://localhost:8000/register/request-to-submit
  2. Check for new field "Registration Year" on top of form, and ensure it accepts no values other than int values starting at 2023
  3. On successful submit of form, go to https://localhost:8000/administration/list-registration-requests and confirm your record is on the table and the registration year you entered shows up in the corresponding 'Registration Year' column
  4. On that record, go to 'View Record' action in the 'Actions' drop down and confirm the registration year shows up there
  5. Now, on the 'Edit Record' action, write a different value in the 'Registration Year' and submit that change
  6. On reload, confirm the changed year is in those same places
  7. Go to https://localhost:8000/register/list-registration-requests and initiate a registration renewal
  8. On the renewal form, confirm the value for 'Registration Year' is pre-populated with the registration year of the record you are renewing + 1 (i.e. for a record w/ registration year 2023, this field should show 2024)
  9. Submit registration renewal and, on https://localhost:8000/administration/list-registration-requests, confirm the correct year is shown on the record

UI

Registration Form
image

View Registration modal
image

@sophia-massie
Copy link
Contributor

Thanks Garrett! Just a couple of bugs I'm seeing:

  • I put in year 11111 and it didn't stop me from inserting that. Is that ok?

  • I'm getting a bug where if I select a type of file, it's not letting me submit.

Screenshot 2023-11-10 at 2 38 14 PM

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few bugs that need addressing but should be good to go after that.

@sophia-massie
Copy link
Contributor

Thanks Garrett! Just a couple of bugs I'm seeing:

  • I put in year 11111 and it didn't stop me from inserting that. Is that ok?
  • I'm getting a bug where if I select a type of file, it's not letting me submit.

Screenshot 2023-11-10 at 2 38 14 PM

Actually, is this because I selected a provider file? Does that not count as a required selection?

@edmondsgarrett
Copy link
Contributor Author

Thanks Garrett! Just a couple of bugs I'm seeing:

  • I put in year 11111 and it didn't stop me from inserting that. Is that ok?
  • I'm getting a bug where if I select a type of file, it's not letting me submit.

Screenshot 2023-11-10 at 2 38 14 PM

Actually, is this because I selected a provider file? Does that not count as a required selection?

Hey Sophia, correct, Blayton from UTH specified that only Medical, Pharmacy, and/or Dental must be chosen; Provider is still optional.

@edmondsgarrett
Copy link
Contributor Author

edmondsgarrett commented Nov 10, 2023

Thanks Garrett! Just a couple of bugs I'm seeing:

  • I put in year 11111 and it didn't stop me from inserting that. Is that ok?
  • I'm getting a bug where if I select a type of file, it's not letting me submit.

Screenshot 2023-11-10 at 2 38 14 PM

Good point, I meant to put a realistic upper bound on that field, I'll add that now

@happycodemonkey
Copy link
Member

Did we want to disable the text box scroll thing here? Should be fine for now if that's a lot of extra effort

@happycodemonkey
Copy link
Member

Did we want to disable the text box scroll thing here? Should be fine for now if that's a lot of extra effort

It doesn't seem to be scrolling with the mouse so safe to ignore i'd say

Copy link
Member

@happycodemonkey happycodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@edmondsgarrett edmondsgarrett merged commit d7da1f2 into main Nov 10, 2023
@edmondsgarrett edmondsgarrett deleted the task/WP-383--registration_year-for-renewal branch November 10, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants