Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(demdata_cms): delete a.k.a. migrate to core-cms-custom #173

Merged
merged 32 commits into from
Jun 22, 2023
Merged

feat(demdata_cms): delete a.k.a. migrate to core-cms-custom #173

merged 32 commits into from
Jun 22, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 1, 2023 •
edited

Overview

Migrate DemData code to https://github.com/TACC/Core-CMS-Custom/.

Changes

  • deleted demdata_cms

Testing

Build and deploy CMS using TACC/Core-CMS-Custom#164.

Archived

Do Not Merge

This PR exists only to review diff of branch with which to build demdata-cms images.

Overview

Add CSS from snippets in (dev) TUP CMS (from https://github.com/TACC/tup-ui).

Related

Changes

Testing

  1. Build CMS image for demdata-cms off of Core-CMS branch /task/demdata-css-from-tup.
  2. Open localhost or https://prod.democratizing-site.tacc.utexas.edu/.
  3. Verify resources load a site.cms.css not a site.css.
  4. Verify two "Standard" and "Full Width" snippets are available, the second of each is "… (with CSS from TUP)".
  5. Change any page to use either "… (with CSS from TUP)" template.
  6. Verify:
    • Styles change. (The more different content on the page, the more obvious the change.)
    • Core styles assets are loaded (e.g. core-styles.base.css, core-styles.cms.css).
    • Many <style> tags are loaded at the bottom of the <head>.

UI

…

Notes

About the snippets: https://github.com/TACC/Core-CMS-Resources/blob/task/demdata-css-from-tup/demdata-cms/templates/from-tup-cms/README.md

Progress toward a consistent programmatic way to support a light header: TACC/Core-Styles#134

@wesleyboar wesleyboar added the alternative Alternative solution(s) exist label Mar 1, 2023
@wesleyboar wesleyboar mentioned this pull request Mar 1, 2023
Merged
@wesleyboar wesleyboar changed the title chore(demdata-cms): settings extra spaces & typos feat(demdata-cms): css snippets from tup cms Mar 1, 2023
@wesleyboar wesleyboar mentioned this pull request Mar 2, 2023
Merged
@wesleyboar
fix(demdata-cms): header height
d85c44c 
this change is synced to tup cms
@wesleyboar wesleyboar mentioned this pull request Mar 2, 2023
Merged
@wesleyboar wesleyboar marked this pull request as ready for review March 2, 2023 04:34
@wesleyboar wesleyboar added enhancement Improvements or additions to existing features and removed alternative Alternative solution(s) exist labels Mar 2, 2023
@wesleyboar wesleyboar marked this pull request as draft March 2, 2023 05:01
@wesleyboar wesleyboar changed the base branch from main to django/2to3 June 22, 2023 17:47
@wesleyboar wesleyboar changed the title feat(demdata-cms): css snippets from tup cms feat(demdata_cms): delete a.k.a. migrate to core-cms-custom Jun 22, 2023
@wesleyboar wesleyboar marked this pull request as ready for review June 22, 2023 22:06
@wesleyboar wesleyboar merged commit 19661d8 into django/2to3 Jun 22, 2023
@wesleyboar wesleyboar deleted the task/demdata-css-from-tup branch June 22, 2023 22:06
@wesleyboar wesleyboar mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvements or additions to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wesleyboar