Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demdata-cms): rename, update, fix #164

Merged
merged 44 commits into from
Jun 23, 2023
Merged

fix(demdata-cms): rename, update, fix #164

merged 44 commits into from
Jun 23, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 25, 2023 •
edited
Loading

Overview

Make DemData CMS be maintained and built in this repo, instead of https://github.com/TACC/Core-CMS-Resources/.

Related

Changes

  • removed cruft files
  • changed cms docker image tag
  • added settings and default secrets
  • changed dir names to demdata_cms (for Django 3)
  • changed settings
  • added project images

Testing

  1. Deploy using cms image tag of a build of this branch.
  2. Open https://pprd.democratizing-site.tacc.utexas.edu/.
  3. Verify it looks like Core-CMS v3.10-ish, but with:
    • DemData logo
    • no logos in branding bar (top part of header)
  4. Re-deploy using cms image tag that production uses.
  5. Verify it looks like Core-CMS v3.10-ish, but with:
    • DemData logo
    • two logos in branding bar (top part of header)

UI

Old Build, Old Styles, Test Content

Skipped, based on more useful tests succeeding.

local staging prod
— — ⊗

New Build, Old Styles, Test Content

local staging prod
pprd, new build, old styles local, new build, old styles ⊗

New Build, New Styles, Test Content

Tested successful, but I lost the screenshots.

local staging prod
✓ ✓ ⊗

Prod Content

staging & prod
demdata

@wesleyboar wesleyboar changed the title fix(demdata-cms): Core-CMS-Resources images fix(demdata-cms): rename to demdata_cms, update and fix it May 25, 2023
wesleyboar added a commit that referenced this pull request May 25, 2023
@wesleyboar
chore(matcssi_cms): remove extra __init__.py
109712a 
Successfully tested via demdata_cms:
- #164 @ e498278
- https://github.com/TACC/Core-CMS-Custom/actions/runs/5084439202/jobs/9136734724
wesleyboar added a commit that referenced this pull request May 25, 2023
@wesleyboar
chore(demdata-cms): rename to demdata_cms
d7b37da 
Django 3+ requries this change. And so will PR #164.
@wesleyboar wesleyboar mentioned this pull request May 25, 2023
Merged
@wesleyboar wesleyboar marked this pull request as ready for review May 25, 2023 21:57
@wesleyboar wesleyboar changed the title fix(demdata-cms): rename to demdata_cms, update and fix it fix(demdata-cms): rename, update, fix 🧪 May 25, 2023
@wesleyboar wesleyboar changed the title fix(demdata-cms): rename, update, fix 🧪 fix(demdata-cms): rename, update, fix ❓ May 25, 2023
@wesleyboar wesleyboar marked this pull request as draft May 25, 2023 22:18
@wesleyboar wesleyboar changed the title fix(demdata-cms): rename, update, fix ❓ fix(demdata-cms): rename, update, fix May 25, 2023
@wesleyboar wesleyboar changed the title fix(demdata-cms): rename, update, fix ⏸️ fix(demdata-cms): rename, update, fix Jun 21, 2023
@wesleyboar wesleyboar mentioned this pull request Jun 22, 2023
Merged
@wesleyboar wesleyboar mentioned this pull request Jun 22, 2023
Merged
@wesleyboar wesleyboar marked this pull request as ready for review June 23, 2023 21:11
@wesleyboar wesleyboar merged commit adc94e9 into main Jun 23, 2023
@wesleyboar wesleyboar deleted the fix/demdata_cms branch June 23, 2023 21:12
wesleyboar added a commit to TACC/Core-CMS-Resources that referenced this pull request Jun 23, 2023
@wesleyboar
chore(demdata): delete dir
101dbe2 
Since TACC/Core-CMS-Custom#164, we do not build DemData from here.
This was referenced Jun 23, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar