Skip to content

PR Submission Guidelines

Jump to bottom
Sal Tijerina edited this page Oct 6, 2022 · 8 revisions

PR Submissions

When creating a new PR, the PR template will include a few pre-populated fields. Make sure to update things like the Jira task id, add relevant photos, and assign 2 reviewers.

After submission

When submitting a PR, make a post in the #cepv2_dev Slack channel to notify the team that the PR is up, and initiate a discussion thread on the post, tagging the reviewers on Slack.

e.g.

New PR: FP-1234 Backend Enhancements

In thread:

@stijerina @Nathan Franklin

As a reviewer, when you have completed a review, tag the PR Author on Slack, for example in the thread mentioned above. As an author, when you have addressed comments, tag the reviewers again on Slack.

TACC ACI WMA Core-Portal Project Documentation

Add links to pages (syntax) to provide organization or hierarchy.

Clone this wiki locally