Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): hide vert overflow inside icon (from wrapped text) #88

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

wesleyboar
Copy link
Member

Overview

Hide vertical overflow inside icon (from wrapped text).

Related

Changes

  • added height to hide vertical overflow

Testing

  1. Create an icon with much text inside.

    <i class="icon icon-user">Lorem ipsum is really long text. And just like any text, it can wrap.</i>
    
  2. Render the icon.

  3. Verify icon is visible.

  4. Verify text not visible.

UI

hotfix icon vert overflow

This is a hotfix for the hotfix #86.
@wesleyboar wesleyboar merged commit 382ab54 into main Dec 13, 2022
@wesleyboar wesleyboar deleted the hotfix/hide-icon-text-more branch December 13, 2022 18:16
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Dec 13, 2022
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant