Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tup-cms): update django to v3.2 #225

Merged
merged 16 commits into from
May 3, 2023
Merged

feat(tup-cms): update django to v3.2 #225

merged 16 commits into from
May 3, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 21, 2023

Overview / Changes

Use CMS image from TACC/Core-CMS#631.

Related

Changes

  • changed CMS image in Dockerfile
  • changed staticfiles to static in templates
  • changed app congif names to start with apps.
  • changed postgresql_psycopg2 (deprecated alias) to postgresql in Database setting
  • changed tup-cms to tup_cms in taccsite_custom (and references to it in there)

Testing

  1. Follow steps from Update to Django 3.2 (for TUP CMS) Core-CMS#626.
  2. Test the following plugins are still editable and still render accurately:
    • Link
    • Filer
    • Blog
    • Page Meta
    • Bootstrap:
      • Container
      • Row
      • Column
      • Picture
    • Text
    • Icon

UI

Django CMS v3.8 New Admin UI Homepage Unchanged
new admin ui in django cms 3 8 dev homepage unchanged
News List News Article - Top News Article - Middle Page Footer
news list news article - top news article - middle footer
Home Page Apps User Updates List User Updates Item Login
home page apps user updates item user updates list login

Notes

Known Issues

  1. TUP-477: Admin Can Not Edit "in Situ" on Page Except Plugins

Reminders

  1. Django 3.8 Upgrade Steps

    • python manage.py migrate — auto-run on deploy
    • python manage.py cms fix-tree — manually run by tup-ui lead dev 05-02-2023 @ 12:30 pm

@wesleyboar
Copy link
Member Author

wesleyboar commented Apr 22, 2023

@wesleyboar
Copy link
Member Author

@jarosenb checked the docker logs on the deploy. The hyphen problem still exists (because Core-CMS still has Core-CMS-Resources within it).

django.core.exceptions.ImproperlyConfigured: The app label 'texascale-org' is not a valid Python identifier.

@wesleyboar
Copy link
Member Author

The CMS loads locally using Core-CMS image from build job #1057 (the tag for that image was added in 6816874).

local tup cms run with core cms image from build job 1057

@wesleyboar
Copy link
Member Author

The CMS loads on dev server using same code from most recent local test.

dev server loads django 3

@wesleyboar wesleyboar marked this pull request as ready for review May 2, 2023 23:13
@wesleyboar wesleyboar marked this pull request as draft May 3, 2023 00:23
TACC/Core-CMS#630

Previous attempt was using CMS image built off of wrong branch.
TACC/Core-CMS#631

Previous attempt was using CMS image built off of ANOTHER wrong branch.
@wesleyboar wesleyboar marked this pull request as ready for review May 3, 2023 15:51
@wesleyboar wesleyboar changed the title test: update django to v3.2 feat(tup-cms): update django to v3.2 May 3, 2023
@wesleyboar wesleyboar merged commit 0acebcf into main May 3, 2023
@wesleyboar wesleyboar deleted the django/2to3 branch May 3, 2023 21:00
@wesleyboar
Copy link
Member Author

The admin ui bugs are not worth holding off on deploying this. They have been deemed negligible by lead CMS admin and I.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant