Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tup-cms): build ui demo if core-cms will not 🧪 #236

Closed

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 23, 2023

Overview

Build the UI demo, so:

  • Core-CMS need not build it for sites that don't use it.
  • TUP CMS can apply its custom styles.
Why?

Core-CMS images take very long to build.

One of the largest layers is building the demo.

The demo is only used on TUP CMS and CEP.

I propose only building it for sites that load it.

Important
Closed, because it adds too much time to the TUP CMS build.

Related

Changes

  • changed core-cms image tag
  • added ui demo build step to dockerfile

Testing

  1. Verify build succeeds.
  2. Verify demo is accessible e.g. https://dev.tup.tacc.utexas.edu/static/ui/.

UI

Dev
Screenshot 2023-08-28 at 2 59 43 PM

Core-CMS images take very logn to build.

One of the largest layers is building the demo.

The demo seems to only work on TUP-CMS.
@wesleyboar wesleyboar changed the title test(tup-cms): build ui demo cuz core-cms will not test(tup-cms): build ui demo cuz core-cms will not 🧪 May 23, 2023
@wesleyboar wesleyboar mentioned this pull request Jun 29, 2023
@wesleyboar wesleyboar changed the title test(tup-cms): build ui demo cuz core-cms will not 🧪 test(tup-cms): build ui demo if core-cms will not 🧪 Aug 25, 2023
@wesleyboar wesleyboar mentioned this pull request Aug 28, 2023
Closed
@wesleyboar
Copy link
Member Author

This adds too much time to the build.

I think there is a better way to not build for every CMS, but also cache the demo (perhaps isolate its build).

@wesleyboar wesleyboar closed this Aug 28, 2023
@wesleyboar wesleyboar deleted the task/build-demo-because-core-will-not-auto-include-it branch October 10, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant