Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tup 584 redesign news metadata #443

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 8, 2024

Overview

Redesign news metadata.

Related

Changes

  • re-ordered share links
  • changed position of news article metadata

Testing

Deployed to dev server.
If testing locally, run npx nx build tup-cms && npx nx serve tup-cms.

  1. Open news list.
  2. Compare to production.
  3. Open any news article that has an author.
  4. Compare that article to production.
  5. Review design UI and responsiveness and usability.
  6. Verify I got designer approval.

UI

Article Page

Before After
page before page after
Mouse
e.g. typical Desktop
Touch
e.g. typical Mobile
page after - mouse page after - touch
Share.Links.on.Hover.mov

Article List Item

Before After
list before list after

Notes

Known Issues

1. Extra Space Between Short Category tag and Publish Date

to fix, refactor grid into flex; might require changing markup
excess space
grid

The mini-refactor may not be worth the effort, especially give a News markup and CSS refactor already scheduled this year.

* feat: set share platforms in repo code

* feat: order share platforms via setting
@wesleyboar wesleyboar marked this pull request as draft March 8, 2024 22:28
@wesleyboar wesleyboar marked this pull request as ready for review March 15, 2024 19:18
Copy link
Contributor

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wesleyboar
Copy link
Member Author

I've logged a Known Issue at the bottom of the Description, "Extra Space Between Short Category tag and Publish Date".

@wesleyboar wesleyboar merged commit 83dcb26 into main Mar 18, 2024
1 check passed
@wesleyboar wesleyboar deleted the feat/tup-584-news-metadata branch March 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants