feat: tup 584 redesign news metadata #773
Conversation
* feat: TUP-553 hide byline prefix * docs: TUP-553 simpler byline comments * feat: TUP-553 new byline layout * feat: TUP-553 new byline layout, page vs list
* feat: TUP-568 new date layout, split date and byline * fix: TUP-568 revert published text change (diff ticket will do this) * fix: TUP-568 revert social icons whitespace fix (diff PR will do this)
* feat: TUP-568 new date layout, split date and byline * fix: TUP-568 revert published text change (diff ticket will do this) * fix: TUP-568 revert social icons whitespace fix (diff PR will do this) * feat: TUP-568 match design of time, cleanup organizational comments
wesleyboar
changed the title
|
|
||
| #: djangocms-blog | ||
| #: templates/djangocms_blog/includes/blog_meta.html:6 | ||
| msgid "by" | ||
| msgstr "by:" | ||
|
|
There was a problem hiding this comment.
But… but we still use trans "by" in Core-CMS blog_meta.html… ?! Yes. This deletion just removes our custom text for it, and uses "by" as is.
| grid-template-areas: | ||
| 'cats' | ||
| 'tags' | ||
| 'attr' | ||
| 'head' | ||
| 'subh'; |
There was a problem hiding this comment.
Why?! Instead of defining the layout of metadata once here, I define it for both …item.css and …page.css.
| /* To always hide byline prefix */ | ||
| .app-blog .byline > span { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Why even have trans "by" if you're not gonna use it? So another site can choose to show it, designers can change their mind, and I can continue to match the template I cloned and overwrite from the blog app1.
Footnotes
-
Until I finally give in and make it my own, because the default template is not gospel, Wes; it's just an example. ↩
|
Warning Given a short category name and a longer author name, the date will not be next to the category name: 
|
Overview
Redesign news metadata.
Status
fix bug with short category, long author, and any dateLeaving this as is. I do not want to refactor CSS grid to flex for this tiny bit of space. There is already a news CSS migration and a planned news CSS refactor coming. I can revisit then.
Related
Changes
See all PRs merged to this branch.
Testing
UI
Article Page
e.g. typical Desktop
e.g. typical Mobile
Share.Links.on.Hover.mov
Article List Item