Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass allow/disallow query param to appropriate ids within manifest #52

Merged
12 commits merged into from
Mar 23, 2019
Merged

pass allow/disallow query param to appropriate ids within manifest #52

12 commits merged into from
Mar 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2019 •
edited by ghost

Code looks good to me.

jcreel and others added 12 commits March 4, 2019 16:45
@jcreel
WIP using allowed/disallowed params when creating Fedora PCDM present…
4798ef3 
…ation manifests
@jcreel
Completed allow/disallow parameterized ids for Fedora PCDM manifests,…
082ac2f 
… abstracted utility to generate the ids
@jcreel
DSpace RDF collection manifests persisting params
3bb4e57
@jcreel
fixed bug in string utility to parameterize url/id method (was using …
5120660 
…wrong param names). Added a unary version of the function
@jcreel
cleanup variable assignments in DSpace generate collection method whe…
00ebd3c 
…n parameterizing the handle/id
@jcreel
allow/disallow parameters applied at sequence and canvas level for Fe…
67e6f16 
…dora PCDM. Cleanup some calls to parameterize string util.
@jcreel
DSpace RDF gets parameters all the way through image manifest.
97a815f
@jcreel
Fix allow/disallow list to match API spec - semicolon delimter, not c…
272374c 
…omma.
@jcreel
Test coverage for allow/disallow on DSpace RDF presentation manifests.
4c5f90d
@jcreel
Test data for allow/disallow cases
53c7e27
@jcreel
WIP progress on Fedora allow/disallow tests
2fab244
@wwelling
minor refactoring, fixed fedora presentation tests
821f51e
@ghost ghost requested review from jcreel and jsavell March 23, 2019 04:09
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 90.448% when pulling 821f51e on store-allow-disallow-in-manifest-id into 14948cb on master.

jcreel
jcreel approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@jcreel jcreel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor of variables. Consistent with established pattern of new variables for the parameterized ids.

@ghost ghost merged commit 99fee85 into master Mar 23, 2019
@ghost ghost deleted the store-allow-disallow-in-manifest-id branch March 23, 2019 15:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsavell jsavell Awaiting requested review from jsavell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coveralls @jcreel @wwelling