Refactor Remote Products to Remote Projects #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always associate the product received by remote products such as LSSS. This requires redesigning the Service and UI to associate with a given product. Whereas before, the product was only associated on push, the product is now associated on create/edit.
This includes fixing the URL.
Remote Projects should not be under the Product URL.
A new controller is brought in for providing `/projects/remote/by-product/{productId}`.
Fetching all remote projects was moved out of the `/products` URL and into the `/remote-project-manager` URL as follows:
- `/remote-project-manager/{remoteProjectManagerId}/remote-projects`
- `/remote-project-manager/{remoteProjectManagerId}/remote-projects/{scopeId}`
Pull Request Test Coverage Report for Build 370
💛 - Coveralls |
rladdusaw
suggested changes
May 19, 2020
src/main/java/edu/tamu/app/cache/controller/RemoteProjectsCacheController.java
Show resolved
Hide resolved
src/main/java/edu/tamu/app/cache/service/RemoteProjectsScheduledCacheService.java
Show resolved
Hide resolved
|
@rladdusaw changes to the existing API would be breaking and not within scope of the issue. These endpoints are being consumed by the project board Michael created. I suggest we produce a specification to decide API naming and then create issues for the changes.
|
@wwelling |
This needs further discussion.
rladdusaw
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes fixing the URLs.Remote Projects should not be under the Product URL.A new controller is brought in for providing/projects/remote/by-product/{productId}.Fetching all remote projects was moved out of the/productsURL and into the/remote-project-managerURL as follows:-/remote-project-manager/{remoteProjectManagerId}/remote-projects-/remote-project-manager/{remoteProjectManagerId}/remote-projects/{scopeId}Resolves #85