Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Remote Products to Remote Projects #90

Merged
merged 8 commits into from
May 21, 2020
Merged

Refactor Remote Products to Remote Projects #90

merged 8 commits into from
May 21, 2020

Commits on May 18, 2020

  1. Follow up on changes to internal cards, stats 

    Always associate the product received by remote products such as LSSS.
This requires redesigning the Service and UI to associate with a given product.
Whereas before, the product was only associated on push, the product is now associated on create/edit.
    @kaladay
    kaladay committed May 18, 2020
    Configuration menu
    Copy the full SHA
    b698e77 View commit details
    Browse the repository at this point in the history

  2. Get the java tests working after changing Internal Requests Product I… 

    …d to Product
    @kaladay
    kaladay committed May 18, 2020
    Configuration menu
    Copy the full SHA
    e89d6fc View commit details
    Browse the repository at this point in the history

  3. Perfmor NULL check on remoteProductManagerRepo.findAll()

    @kaladay
    kaladay committed May 18, 2020
    Configuration menu
    Copy the full SHA
    634d10e View commit details
    Browse the repository at this point in the history

  4. Attempt to get tests passing

    @kaladay
    kaladay committed May 18, 2020
    Configuration menu
    Copy the full SHA
    70beb78 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Refactor Remote Product to Remote Project, renaming the files

    @kaladay
    kaladay committed May 19, 2020
    Configuration menu
    Copy the full SHA
    e0fa3c6 View commit details
    Browse the repository at this point in the history

  2. Issue 85: refactor Remote Product to Remote Project 

    This includes fixing the URL.
Remote Projects should not be under the Product URL.

A new controller is brought in for providing `/projects/remote/by-product/{productId}`.

Fetching all remote projects was moved out of the `/products` URL and into the `/remote-project-manager` URL as follows:
- `/remote-project-manager/{remoteProjectManagerId}/remote-projects`
- `/remote-project-manager/{remoteProjectManagerId}/remote-projects/{scopeId}`
    @kaladay
    kaladay committed May 19, 2020
    Configuration menu
    Copy the full SHA
    cf6418d View commit details
    Browse the repository at this point in the history

  3. Remove accidentally committed debug statements

    @kaladay
    kaladay committed May 19, 2020
    Configuration menu
    Copy the full SHA
    83dae9e View commit details
    Browse the repository at this point in the history

  4. Partially revert relocation of endpoints 

    This needs further discussion.
    @kaladay
    kaladay committed May 19, 2020
    Configuration menu
    Copy the full SHA
    a554ea9 View commit details
    Browse the repository at this point in the history