Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 351: Wrong label "Create Writer" on the "more..." paginated modal for selecting facets. #471

Merged

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Dec 8, 2022

Description

Use the name of the facets, adding it to the scope so for the modal to use.

Fixes #351

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually viewing after change.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings

…al for selecting facets.

Use the name of the facets, adding it to the scope so for the modal to use.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 45.264% when pulling afba86e on 2022_dec-351-paginated_more_name into 5423c43 on 2022_dec-techdebt-staging.

@kaladay kaladay merged commit b125a3f into 2022_dec-techdebt-staging Dec 9, 2022
@kaladay kaladay deleted the 2022_dec-351-paginated_more_name branch December 9, 2022 16:57
@rmathew1011 rmathew1011 mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong label "Create Writer" on the "more..." paginated modal for selecting facets
5 participants