Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New timeStamp.cpp file renders fceux x86-only #663

Closed
clausecker opened this issue Sep 5, 2023 · 4 comments
Closed

New timeStamp.cpp file renders fceux x86-only #663

clausecker opened this issue Sep 5, 2023 · 4 comments
Assignees

Comments

@clausecker
Copy link

I'm the maintainer of the FreeBSD port (package) for fceux.

I'm currently trying to update the port to 2.6.6, but had to notice that it now no longer compiles on non-x86. This is because the new file timeStamp.cpp unconditionally tries to use rdtsc, an x86-only feature. Previously it seems this code was guarded under the profiler option and was hence not usually built.

Please provide a code path for this module that runs on non-x86 systems or change the code so it is not required alltogether.

@thor2016 thor2016 self-assigned this Sep 5, 2023
@zeromus zeromus closed this as completed in 3960962 Sep 7, 2023
@thor2016
Copy link
Collaborator

thor2016 commented Sep 7, 2023

Actually this fix will not work for @clausecker because he is using the Qt version. I have a different fix in mind. The TSC was only intended to be a debug feature for profiling. I will take care of it.

@thor2016 thor2016 reopened this Sep 7, 2023
@thor2016
Copy link
Collaborator

thor2016 commented Sep 7, 2023

@clausecker Please try patching commit d2ee635 into your build

@zeromus
Copy link
Contributor

zeromus commented Sep 8, 2023

sorry I made a mess. thanks for fixing it @thor2016

@clausecker
Copy link
Author

Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants