Add new permisison for deleting game entries, resolves #1292

TASVideos · Aug 13, 2022 · fd7512f · fd7512f
1 parent 12c9dc4
commit fd7512f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/TASVideos.Data/Entity/PermissionTo.cs b/TASVideos.Data/Entity/PermissionTo.cs
@@ -158,6 +158,10 @@ public enum PermissionTo
 	[Description("The ability to create and modify publication awards")]
 	CreateAwards = 307,
 
+	[Group("Publication Maintenance")]
+	[Description("The ability to delete a game entry")]
+	DeleteGameEntries = 308,
+
 	[Group("Publication Maintenance")]
 	[Description("The ability to add, edit, and remove the tags used for publications")]
 	TagMaintenance = 390,

diff --git a/TASVideos/Pages/Games/Edit.cshtml b/TASVideos/Pages/Games/Edit.cshtml
@@ -8,7 +8,7 @@
 	string returnUrl = HttpContext.Request.ReturnUrl();
 }
 <form-group>
-	<delete-button condition="@Model.CanDelete" asp-href="/Games/Edit/@(Model.Id ?? 0)?handler=Delete" class="float-end">Delete</delete-button>
+	<delete-button permission="DeleteGameEntries" condition="@Model.CanDelete" asp-href="/Games/Edit/@(Model.Id ?? 0)?handler=Delete" class="float-end">Delete</delete-button>
 </form-group>
 <div class="text-danger">
 	@Html.ValidationSummary()

diff --git a/TASVideos/Pages/Games/Edit.cshtml.cs b/TASVideos/Pages/Games/Edit.cshtml.cs
@@ -162,6 +162,11 @@ public async Task<IActionResult> OnPostDelete()
 			return NotFound();
 		}
 
+		if (!User.Has(PermissionTo.DeleteGameEntries))
+		{
+			return AccessDenied();
+		}
+
 		if (!await CanBeDeleted())
 		{
 			ErrorStatusMessage($"Unable to delete Game {Id}, game is used by a publication or submission.");