Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse VS system #747

Merged
merged 2 commits into from
Jan 13, 2022
Merged

parse VS system #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c75c19
parse VS system
CasualPokePlayer Jan 3, 2022
b893d82
parse VS as Arcade, make test for this
CasualPokePlayer Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions TASVideos.Parsers/Parsers/Bk2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ public async Task<IParseResult> Parse(Stream file)
{
platform = SystemCodes.Sg;
}
else if (header.GetValueFor(Keys.ModeVs).ToBool())
{
platform = SystemCodes.Arcade;
result.FrameRateOverride = 60.0988138974405;
}

result.SystemCode = platform;

Expand Down Expand Up @@ -176,6 +181,7 @@ private static class Keys
public const string ModeSegaCd = "issegacdmode";
public const string ModeGg = "isggmode";
public const string ModeSg = "issgmode";
public const string ModeVs = "isvs";
public const string VBlankCount = "vblankcount";
public const string CycleCount = "cyclecount";
public const string Core = "core";
Expand Down
1 change: 1 addition & 0 deletions tests/TASVideos.MovieParsers.Tests/Bk2ParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public async Task PalFlag_True(string fileName, RegionType expected)
[DataRow("System-Lynx.bk2", SystemCodes.Lynx)]
[DataRow("System-Nes.bk2", SystemCodes.Nes)]
[DataRow("System-Fds.bk2", SystemCodes.Fds)]
[DataRow("System-Vs.bk2", SystemCodes.Arcade)]
[DataRow("System-Gb.bk2", SystemCodes.GameBoy)]
[DataRow("System-Dgb.bk2", SystemCodes.GameBoy)]
[DataRow("System-Gb3x.bk2", SystemCodes.GameBoy)]
Expand Down
Binary file added tests/TASVideos.MovieParsers.Tests/Bk2SampleFiles/System-Vs.bk2
View file
Open in desktop
Binary file not shown.