Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-cjs tests and add CI automated tests #41

Merged
merged 11 commits into from
Oct 16, 2023

Conversation

leordev
Copy link
Member

@leordev leordev commented Oct 13, 2023

  • Also moved the dwn to the top pnpm level
  • Created manual workflow dispatches where we can set the version of web5 and/or dwn (useful for testing alpha releases)
  • Updated the pnpm lock file to version 6, please make sure we are using pnpm 8
  • Upgraded nextjs to version 13.5 to as an attempt to fix a security issue

To run all the tests at once, just run pnpm -r test

Fix #33
Fix #11

@socket-security
Copy link

socket-security bot commented Oct 13, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
next 13.5.4 eval, network, filesystem, shell, environment +0 68.9 MB vercel-release-bot
@docusaurus/core 2.4.3 filesystem, environment +1 477 kB slorber
expo 49.0.13 None +1 3.18 MB brentvatne
webpack-cli 5.1.4 environment +0 110 kB evilebottnawi
react-native 0.72.1 network, filesystem, shell, environment +0 59.6 MB react-native-bot

@socket-security
Copy link

socket-security bot commented Oct 13, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: next@13.5.4

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@leordev leordev marked this pull request as ready for review October 13, 2023 20:43
@leordev
Copy link
Member Author

leordev commented Oct 13, 2023

@SocketSecurity ignore next@13.5.4

This repo does not work with next in a production environment, it only has bundling examples. Only real apps should be taking measures against this security leak (NEXT_TELEMETRY_DISABLED=1).

@leordev leordev merged commit 35dd628 into main Oct 16, 2023
13 of 25 checks passed
@leordev leordev deleted the leordev/issue-33.node-cjs branch October 16, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests scripts to node-cjs GitHub Action Test: Node.js
2 participants