Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for windows in documentation #1028

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

samejima-san
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🧑‍💻 Code Snippet
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other

Description

This PR updates documentation to include Windows, also adds tabs so you can pick your operating system.

Related Tickets & Documents

Resolves #1005

Mobile & Desktop Screenshots/Recordings

Added code snippets?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

codesandbox bot commented Nov 25, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Nov 25, 2023

👷 Deploy request for tbd-website-developer pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6145614

@samejima-san
Copy link
Contributor Author

right now I am having trouble getting the code block to render properly, so i am going to work on this more tomorrow. This PR is just to show progress.

site/package.json Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No impactful change here, can restore this file

site/src/components/ReusableTabs.jsx Outdated Show resolved Hide resolved
@angiejones angiejones marked this pull request as draft November 26, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows-Compatible Curl Commands to SSI Documentation
2 participants