Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated to support abstract specs #141

Merged
merged 11 commits into from
Aug 15, 2022

Conversation

andorsk
Copy link
Contributor

@andorsk andorsk commented Jul 7, 2022

Supports fixes to: #139

@andorsk andorsk marked this pull request as ready for review July 7, 2022 17:43
did/peer_test.go Outdated Show resolved Hide resolved
Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's discuss the metadata objects before continuing

did/model.go Outdated Show resolved Hide resolved
@andorsk
Copy link
Contributor Author

andorsk commented Jul 8, 2022

@decentralgabe I've added some object to support metadata better. Take a look when you get the chance and lmk if you are ok with it.

@andorsk
Copy link
Contributor Author

andorsk commented Jul 26, 2022

I need to eventually bring this back to life. Sorry, been caught up with other things.

@andorsk andorsk marked this pull request as draft August 15, 2022 22:15
@codecov-commenter
Copy link

Codecov Report

Merging #141 (f1cb16b) into main (4ad8843) will increase coverage by 0.01%.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   55.56%   55.57%   +0.01%     
==========================================
  Files          37       37              
  Lines        4044     4045       +1     
==========================================
+ Hits         2247     2248       +1     
  Misses       1412     1412              
  Partials      385      385              
Impacted Files Coverage Δ
did/interface.go 50.00% <ø> (ø)
did/model.go 59.37% <ø> (ø)
did/peer.go 55.89% <32.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andorsk andorsk marked this pull request as ready for review August 15, 2022 22:19
@andorsk
Copy link
Contributor Author

andorsk commented Aug 15, 2022

finally fixed all the pending issues on this one. please take a look when you get the chance.

did/model.go Outdated Show resolved Hide resolved
Co-authored-by: Gabe <gabe.l.cohen@gmail.com>
Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for doing this

@andorsk
Copy link
Contributor Author

andorsk commented Aug 15, 2022

@decentralgabe merci!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants