-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated to support abstract specs #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's discuss the metadata objects before continuing
@decentralgabe I've added some object to support metadata better. Take a look when you get the chance and lmk if you are ok with it. |
I need to eventually bring this back to life. Sorry, been caught up with other things. |
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 55.56% 55.57% +0.01%
==========================================
Files 37 37
Lines 4044 4045 +1
==========================================
+ Hits 2247 2248 +1
Misses 1412 1412
Partials 385 385
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
finally fixed all the pending issues on this one. please take a look when you get the chance. |
Co-authored-by: Gabe <gabe.l.cohen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for doing this
@decentralgabe merci! |
Supports fixes to: #139