Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align versioning across tbDEX subprojects #160

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Align versioning across tbDEX subprojects #160

merged 1 commit into from
Feb 16, 2024

Conversation

ALRubinger
Copy link
Contributor

@ALRubinger ALRubinger commented Feb 12, 2024 •
edited

Fulfills #159.

  • Remove Web5 transitive deps
  • Introduce Version Catalog for tbDEX deps
  • Document and link to issues for API leaks
  • Updates tbdex-kt to web5-kt:0.11.0

What this does not do:

  • Align versions with Web5. Must work incrementally and follow up with that.

Dependency:

@ALRubinger ALRubinger self-assigned this Feb 12, 2024
@ALRubinger ALRubinger changed the title Issue #159 - Centralize versioning in Gradle Version Catalog Centralize versioning for tbDEX SDK for the JVM Feb 12, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024 •
edited

Codecov Report

Merging #160 (0bf3de9) into main (abd246d) will increase coverage by 0.25%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   77.34%   77.59%   +0.25%     
==========================================
  Files          33       33              
  Lines         799      808       +9     
  Branches       80       80              
==========================================
+ Hits          618      627       +9     
  Misses        134      134              
  Partials       47       47
Components Coverage Δ
protocol 84.13% <ø> (+0.04%) ⬆️
httpclient 78.53% <ø> (+0.10%) ⬆️

@ALRubinger ALRubinger changed the title Centralize versioning for tbDEX SDK for the JVM Centralize versioning Feb 12, 2024
@ALRubinger ALRubinger changed the title Centralize versioning Align versioning across tbDEX and Web5 platforms Feb 12, 2024
@ALRubinger ALRubinger force-pushed the issue-159/version-alignment branch 2 times, most recently from d61a61c to 06cf0f6 Compare February 12, 2024 02:14
@ALRubinger
Copy link
Contributor Author

SNAPSHOT publish for testing consumption w/ developer.tbd.website and its test suites: https://s01.oss.sonatype.org/content/repositories/snapshots/xyz/block/web5/0.11.0.issue226-SNAPSHOT/

This was referenced Feb 12, 2024
Closed
Closed
Merged
@ALRubinger ALRubinger force-pushed the issue-159/version-alignment branch 2 times, most recently from ca47898 to 3b6b923 Compare February 15, 2024 07:36
@ALRubinger ALRubinger changed the title Align versioning across tbDEX and Web5 platforms Align versioning across tbDEX subprojects Feb 15, 2024
@ALRubinger
Copy link
Contributor Author

Updated version for SNAPSHOT of web5-kt now that the dependent fixes of this PR are on main there: https://s01.oss.sonatype.org/content/repositories/snapshots/xyz/block/web5/0.11.0-SNAPSHOT/

@ALRubinger ALRubinger mentioned this pull request Feb 15, 2024
Merged
@ALRubinger
Issue #159 - Centralize versioning in Gradle Version Catalog
0bf3de9 
* Remove Web5 transitive deps
* Introduce Version Catalog for tbDEX deps
* Document API Leaks (Issue #161)
* Upgrade to web5-kt 0.11.0
@ALRubinger ALRubinger marked this pull request as ready for review February 15, 2024 20:00
@ALRubinger ALRubinger mentioned this pull request Feb 15, 2024
Closed
@ALRubinger ALRubinger merged commit 7f7fe24 into main Feb 16, 2024
5 of 7 checks passed
@ALRubinger ALRubinger deleted the issue-159/version-alignment branch February 16, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitro-neal nitro-neal nitro-neal approved these changes

@jiyoontbd jiyoontbd jiyoontbd approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew phoebe-lew is a code owner

@michaelneale michaelneale Awaiting requested review from michaelneale michaelneale is a code owner

@KendallWeihe KendallWeihe Awaiting requested review from KendallWeihe KendallWeihe is a code owner

@ethan-tbd ethan-tbd Awaiting requested review from ethan-tbd ethan-tbd is a code owner

@tomdaffurn tomdaffurn Awaiting requested review from tomdaffurn tomdaffurn is a code owner

@diehuxx diehuxx Awaiting requested review from diehuxx diehuxx is a code owner

@kirahsapong kirahsapong Awaiting requested review from kirahsapong kirahsapong is a code owner

Assignees

@ALRubinger ALRubinger

Labels
None yet
Projects
SDK Development
Status: Done
(OLD) Open Source Programs Engineering
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ALRubinger @nitro-neal @jiyoontbd