Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermitize #163

Merged
merged 8 commits into from
Feb 26, 2024
Merged

hermitize #163

merged 8 commits into from
Feb 26, 2024

Conversation

jiyoontbd
Copy link
Contributor

@jiyoontbd jiyoontbd commented Feb 14, 2024

hermit init .
hermit install openjdk@11
hermit install gradle@8.2 # current version per running ./gradlew --version

replaced gradlew wrapper validator action with init hermit step to publish ci and docs yaml

…ion per running ./gradlew --version). replaced gradlew wrapper validator action with init hermit step to publish ci and docs yaml
@jiyoontbd jiyoontbd linked an issue Feb 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Merging #163 (5a372ce) into main (a9224b0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files          33       33           
  Lines         812      812           
  Branches       80       80           
=======================================
  Hits          630      630           
  Misses        135      135           
  Partials       47       47           
Components Coverage Δ
protocol 84.13% <ø> (ø)
httpclient 78.46% <ø> (ø)

Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! pinging the hermit himself @alecthomas anything stand out?

only other thing which comes to my mind is maybe adding relevant developer instructions to the README

@alecthomas
Copy link

Ah yes, one thing: I would suggest not using channels. I'd pin the versions exactly then either manually upgrade them, or use Renovate to manage them - it has Hermit support.

@alecthomas
Copy link

Also, you'll need to add this to your build.gradle.kts file:

tasks.findByName("wrapper")?.enabled = false

That will prevent Gradle from trying to download the wrapper automatically.

@michaelneale
Copy link
Contributor

oh this would be nice - then I don't have to mess around with JVM versions by hand?

@@ -30,7 +32,7 @@ jobs:
key: gradle-${{ runner.os }}-${{ hashFiles('**/*.gradle.kts') }}-${{ hashFiles('**/gradle/wrapper/gradle-wrapper.properties') }}-${{ hashFiles('**/versions.properties') }}

- name: Run Gradle Tasks
run: ./gradlew build koverXmlReport

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it's not necessary to include bin/ here - activate-hermit will add bin to the $PATH for you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@jiyoontbd jiyoontbd merged commit 8c2e13e into main Feb 26, 2024
5 of 7 checks passed
@jiyoontbd jiyoontbd deleted the 131-hermitize branch February 26, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermitize
6 participants