add EdDSA to JwsHeaderParams['alg'] type
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 90.80% 90.81%
=======================================
Files 67 67
Lines 12828 12838 +10
Branches 1268 1268
=======================================
+ Hits 11649 11659 +10
Misses 1156 1156
Partials 23 23
|
|
@mistermoe This change is also included in PR #175 but if there's a pressing need, we can certainly merge as a standalone PR. |
|
Oh nice! Na no worries then. Will close this |
Signed-off-by: Frank Hinek <frankhinek@users.noreply.github.com>
frankhinek
force-pushed
the
jose-jws-header
branch
from
aacf55c
to
3bd18e9
Compare
|
The change was unintentionally removed from PR #175 so merging this to add |
andorsk
pushed a commit
to modernfoundry/web5-js
that referenced
this pull request
Sep 28, 2023
* `[crypto/jose]` add `EdDSA` to `JwsHeaderParams['alg']` --------- Co-authored-by: Frank Hinek <frankhinek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
EdDSA(mentioned in RFC 8037) as an acceptable value forJwsHeaderParams['alg'].