Accept VCs as JSON-LD or JWT when creating Verifiable Presentation #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
ianpatton
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Codecov Report
@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 90.81% 90.81%
=======================================
Files 67 67
Lines 12838 12839 +1
Branches 1268 1268
=======================================
+ Hits 11659 11660 +1
Misses 1156 1156
Partials 23 23
|
nitro-neal
approved these changes
Sep 26, 2023
|
Closing in favor of standardizing on JWT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to create Verifiable Presentations using @web5/credentials, with existing Verifiable Credentials in JSON-LD format.
Pex allows this, but the current implementation limits to strings (jwts)