-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did dht test vectors #181
Did dht test vectors #181
Conversation
…xchange.kt Co-authored-by: Andres Uribe <auribe@tbd.email>
…ationSubmission.kt Co-authored-by: Andres Uribe <auribe@tbd.email>
…ationSubmission.kt Co-authored-by: Andres Uribe <auribe@tbd.email>
return try { | ||
resolveInternal(did) | ||
} catch (e: Exception) { | ||
println(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with a logger.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 80.15% 80.18% +0.03%
==========================================
Files 37 37
Lines 2116 2150 +34
Branches 297 299 +2
==========================================
+ Hits 1696 1724 +28
- Misses 283 288 +5
- Partials 137 138 +1
|
…s' into did_dht_test_vectors
I could be misreading the Kotlin (KT newb 🖐️)... It seems that the web5-kt/test-vectors/did_dht/create.json Lines 7 to 13 in 02932be
But the web5-kt/dids/src/test/kotlin/web5/sdk/dids/methods/dht/DidDhtTest.kt Lines 368 to 369 in 02932be
Had a number of long discussions with Moe and Adam this week on how to approach DID key management across all of our SDKs. It seems there's an opportunity to continue to get feedback from our partners and tweak how |
Your reading is correct. The dht identity key cannot be passed in. There were also other long discussions about the same topic during the ION implementation. The decision at that point in time is that the sdk should allow both paradigms: manually specifying the keys and also automatically creating them. That's the design that motivated
I agree that such a discussion shouldn't block this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankhinek might be good for us to schedule time to discuss key management across the SDK?
private val mapper = jacksonObjectMapper() | ||
|
||
class Web5TestVectorsDidDhtTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should just be Web5TestVectorsDidDht
Overview
Adds test vectors for did:dht for the
create
andresolve
functions. The motivation is to ensure interoperability across implementations of the standard. This PR is related to TBD54566975/web5-spec#11, and will form the basis to fix the issue.Description
This PR includes the following changes:
ExceptionDeclarations.kt
.create
andresolve
.DidDht
so that tests pass.Once this is accepted, the test vectors will be promoted to the
sdk-development
repository.Note
The test vectors were based off of https://did-dht.com/#test-vectors, and adjusted to match our test-vector structure.
How Has This Been Tested?
Unit tests