Discovery Tweaks After Initial Usage #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squelches a bunch of potential discovery log messages that are unnecessary.
Necessary because the modem only uses a single template with an indeterminate, until run time, number of topics generated
The HA implementation of the discovery protocol only allows a very small subset of characters for use in the node_id and the object_id. This replaces all un-allowed characters with an underscore. Also removed the ability to set the topic via yaml. This never really worked anyways and would create potential problems. Reverted changing the periods in the address to underscores, periods are still fine in the unique_id, just not in the topic string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
These are a few small fixes to the Discovery platform that I found while setting it up.
Checklist