Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #610 #907

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NimaSarajpoor
Copy link
Collaborator

@NimaSarajpoor NimaSarajpoor commented Aug 25, 2023

This PR is a replacement for PR #668. This PR tries to resolve the loss of precision issue that might occur in cases where there are identical subsequences (in their z-normalized version) in a time series (see #610)

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6663f5f) 98.93% compared to head (5b79efb) 98.93%.
Report is 3 commits behind head on main.

❗ Current head 5b79efb differs from pull request most recent head 1eb878d. Consider uploading reports for the commit 1eb878d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          84       84           
  Lines       14292    14307   +15     
=======================================
+ Hits        14140    14155   +15     
  Misses        152      152           
Files Changed Coverage Δ
tests/test_precision.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NimaSarajpoor
Copy link
Collaborator Author

Note: A TimeoutError occurred in here

@seanlaw
Copy link
Contributor

seanlaw commented Aug 26, 2023

I re-ran the failed tests

@NimaSarajpoor
Copy link
Collaborator Author

NimaSarajpoor commented Aug 26, 2023

@seanlaw
Thank you for re-running the tests

We can see an assertion failure here. Note that this is coming from the test function in which the identical subsequences are scaled differently, and their values are not in the range of other subsequences. I will dig into it and provide an update.

@NimaSarajpoor
Copy link
Collaborator Author

NimaSarajpoor commented Aug 27, 2023

[Update]
Note: The assertion failure is coming from the distance between two differently-scaled subsequences that have the same values in their z-norm space.

Note 1 : Removing njit decorators do not resolve the assertion failure.
Note 2: Using the exact covariance instead of the rolling one resolves the assertion failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants