Add labels for numerical scale questions (#12148)

TEAMMATES · Mar 23, 2023 · 8ab077e · 8ab077e
1 parent b1fc36a
commit 8ab077e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/web/app/components/question-submission-form/question-submission-form.component.html b/src/web/app/components/question-submission-form/question-submission-form.component.html
@@ -104,6 +104,7 @@ <h2 id="question-details"><b>Question {{ model.questionNumber }}: </b>{{ model.q
                                                     [responseDetails]="recipientSubmissionFormModel.responseDetails"
                                                     (responseDetailsChange)="triggerRecipientSubmissionFormChange(i, 'responseDetails', $event)"
                                                     [isDisabled]="isFormsDisabled"
+                                                    [recipient]="getRecipientName(recipientSubmissionFormModel.recipientIdentifier)"
             ></tm-num-scale-question-edit-answer-form>
             <tm-mcq-question-edit-answer-form *ngIf="model.questionType === FeedbackQuestionType.MCQ" [questionDetails]="model.questionDetails"
                                                     [responseDetails]="recipientSubmissionFormModel.responseDetails"

diff --git a/...estion-types/question-edit-answer-form/num-scale-question-edit-answer-form.component.html b/...estion-types/question-edit-answer-form/num-scale-question-edit-answer-form.component.html
@@ -1,7 +1,7 @@
 <div class="form-row text-start">
   <div class="col-md-3 col-xs-5">
     <input type="number" class="form-control" min="{{ questionDetails.minScale }}" max="{{ questionDetails.maxScale }}" step="{{ questionDetails.step }}" tmDisableWheel
-           [ngModel]="responseDetails.answer === NUMERICAL_SCALE_ANSWER_NOT_SUBMITTED ? '' : responseDetails.answer" (ngModelChange)="triggerResponseDetailsChange('answer', $event)" [disabled]="isDisabled">
+           [ngModel]="responseDetails.answer === NUMERICAL_SCALE_ANSWER_NOT_SUBMITTED ? '' : responseDetails.answer" (ngModelChange)="triggerResponseDetailsChange('answer', $event)" [disabled]="isDisabled" [attr.aria-label]="getAriaLabel()">
   </div>
   <div id="possible-values" class="col-md-9 col-xs-6 text-secondary">
     Possible values: {{ possibleValues }}

diff --git a/...sion/session-submission-page/__snapshots__/session-submission-page.component.spec.ts.snap b/...sion/session-submission-page/__snapshots__/session-submission-page.component.spec.ts.snap
@@ -1860,6 +1860,7 @@ exports[`SessionSubmissionPageComponent should snap with feedback session questi
                           class="col-md-3 col-xs-5"
                         >
                           <input
+                            aria-label="Response for Barry Harris"
                             class="form-control ng-untouched ng-pristine ng-valid"
                             max="10"
                             min="1"
@@ -4531,6 +4532,7 @@ exports[`SessionSubmissionPageComponent should snap with feedback session questi
                           class="col-md-3 col-xs-5"
                         >
                           <input
+                            aria-label="Response for Barry Harris"
                             class="form-control ng-untouched ng-pristine ng-valid"
                             max="10"
                             min="1"