Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected behaviour when reverting to template feedback path #10917

Closed
madanalogy opened this issue Jan 15, 2021 · 4 comments · Fixed by #10975
Closed

Unexpected behaviour when reverting to template feedback path #10917

madanalogy opened this issue Jan 15, 2021 · 4 comments · Fixed by #10975
Labels
c.Bug Bug/defect report p.Low Very little impact; unlikely to do in the near future

Comments

@madanalogy
Copy link
Contributor

Environment: Live server at V7.8.0

Steps to reproduce

  1. Add new essay question to a feedback session
  2. Change feedback path to custom feedback path
  3. Attempt to revert feedback path to preset template provided

Expected behaviour
User interface reverts to template display prior to selecting custom feedback path

Actual behaviour
User interface does not change and the visibility options are reset to "deny all"

Additional info
Jan-16-2021 00-04-05
@madanalogy madanalogy added p.Low Very little impact; unlikely to do in the near future c.Bug Bug/defect report t-Angular labels Jan 15, 2021
@t-cheepeng
Copy link
Contributor

t-cheepeng commented Jan 16, 2021 •
edited
Loading

Possible duplicate of #10579

@madanalogy
Copy link
Contributor Author

Anyone addressing this issue then should just focus on the UI component and leave the feedback path portion alone

@stapletonce
Copy link
Contributor

Does this bug still need to be worked on?

@madanalogy
Copy link
Contributor Author

Yeap, feel free to give it a shot and let us know if you have any questions or run into any problems

@stapletonce stapletonce mentioned this issue Feb 21, 2021
Merged
madanalogy added a commit that referenced this issue Apr 12, 2021
@stapletonce @moziliar
@Derek-Hardy @madanalogy
[#10917] Fix unexpected behaviour when reverting to template feedback…
0e533b2 
… path (#10975)

* Fix unexpected behaviour when reverting to template feedback path

* Fix minor linting errors

* Check if settings are same when reverting from custom to default

* Remove redundancies from if checks

* Revert to default display after choosing common feedback settings after a custom feedback setting

* Update src/web/app/components/question-edit-form/question-edit-form.component.ts

Co-authored-by: Mo Zongran <mzongran@comp.nus.edu.sg>

* Revert "Update src/web/app/components/question-edit-form/question-edit-form.component.ts"

This reverts commit 3626115.

Co-authored-by: Chloe Stapleton <ces@MacBook-Pro.lan>
Co-authored-by: Mo Zongran <mzongran@comp.nus.edu.sg>
Co-authored-by: Derek-Hardy <32880438+Derek-Hardy@users.noreply.github.com>
Co-authored-by: Ahmed Bahajjaj <Ahmed_Bahajjaj@u.nus.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Bug Bug/defect report p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#10917] Fix unexpected behaviour when reverting to template feedback path stapletonce/teammates
3 participants
@t-cheepeng @madanalogy @stapletonce