Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove appengine.api.datastore usage after Objectify v6 upgrade #11001

Closed
Derek-Hardy opened this issue Mar 3, 2021 · 1 comment
Closed

Remove appengine.api.datastore usage after Objectify v6 upgrade #11001

Derek-Hardy opened this issue Mar 3, 2021 · 1 comment
Assignees
@Derek-Hardy @jianhandev
Labels
a-Storage Database schema, Datastore-related technologies/quirks c.Task Other non-user-facing works, e.g. refactoring, adding tests
Projects
GAE Runtime Upgrade

Comments

@Derek-Hardy
Copy link
Contributor

  • Environment: objectify-v6-migration branch

After upgraded Objectify to v6, we should no longer rely on any com.google.appengine.api.datastore.* usage.

There are still some leftover code to be cleaned up:

import com.google.appengine.api.datastore.Text;
in src/main/java/teammates/storage/entity/FeedbackQuestion.java

import com.google.appengine.api.datastore.Text;
in src/main/java/teammates/storage/entity/FeedbackResponse.java

import com.google.appengine.api.datastore.Text;
in src/main/java/teammates/storage/entity/FeedbackResponseComment.java

import com.google.appengine.api.datastore.Text;
in src/main/java/teammates/storage/entity/FeedbackSession.java

import com.google.appengine.api.datastore.Text;
in src/main/java/teammates/storage/entity/Instructor.java

import com.google.appengine.api.datastore.Text;
in src/main/java/teammates/storage/entity/StudentProfile.java

import com.google.appengine.api.datastore.DatastoreTimeoutException;
in src/e2e/java/teammates/e2e/cases/SystemErrorEmailReportE2ETest.java

import com.google.appengine.api.datastore.DatastoreTimeoutException;
in src/main/java/teammates/ui/webapi/AdminExceptionTestAction.java

import com.google.appengine.api.datastore.DatastoreTimeoutException;
in src/main/java/teammates/ui/webapi/WebApiServlet.java

import com.google.appengine.api.datastore.DatastoreTimeoutException;
in src/test/java/teammates/ui/webapi/WebApiServletTest.java

.should().accessClassesThat().haveFullyQualifiedName("com.google.appengine.api.datastore.Text") line510
in src/test/java/teammates/architecture/ArchitectureTest.java
@Derek-Hardy Derek-Hardy added t-GAE a-Storage Database schema, Datastore-related technologies/quirks c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Mar 3, 2021
@Derek-Hardy Derek-Hardy added this to To do in GAE Runtime Upgrade via automation Mar 3, 2021
This was referenced Mar 7, 2021
Merged
Merged
Derek-Hardy pushed a commit that referenced this issue Mar 12, 2021
@jianhandev
[#11001] Migrate App Engine Text datastore type (#11019)
b0fcb4e 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
@jianhandev jianhandev mentioned this issue Mar 16, 2021
Merged
@wkurniawan07 wkurniawan07 moved this from To do to Done in feature branch in GAE Runtime Upgrade Mar 17, 2021
wkurniawan07 pushed a commit that referenced this issue Mar 18, 2021
@jianhandev
[#11001] Handle datastore exceptions using the new Google-provided SDK (
0bf194b 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
Derek-Hardy pushed a commit that referenced this issue Mar 18, 2021
@jianhandev
[#11001] Final cleanup for Objectify V6 migration (#11034)
eec938d 
* Remove usage of Text in FeedbackResponse class

* Clean up constructors
wkurniawan07 pushed a commit that referenced this issue Mar 22, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
bbb84e2 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue Mar 22, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
a16b6b5 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
wkurniawan07 pushed a commit that referenced this issue Mar 22, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
c4ab65a 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue Mar 22, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
de43abe 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
wkurniawan07 pushed a commit that referenced this issue Mar 23, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
67ee692 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue Mar 23, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
355e734 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
@wkurniawan07
Copy link
Member

Work is done

wkurniawan07 pushed a commit that referenced this issue Apr 28, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
c575fe1 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue Apr 28, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
86d9924 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
wkurniawan07 pushed a commit that referenced this issue May 3, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
17bc3a7 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue May 3, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
2f37602 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
wkurniawan07 pushed a commit that referenced this issue Jun 2, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
900c044 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue Jun 2, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
01161b4 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
wkurniawan07 pushed a commit that referenced this issue Jun 6, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
ec9d720 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue Jun 6, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
7a0a93a 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
wkurniawan07 pushed a commit that referenced this issue Jun 6, 2021
@jianhandev @wkurniawan07
[#11001] Migrate App Engine Text datastore type (#11019)
217e85e 
* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
wkurniawan07 pushed a commit that referenced this issue Jun 6, 2021
@jianhandev @wkurniawan07
[#11001] Handle datastore exceptions using the new Google-provided SDK (
e0e3b8a 
#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
@wkurniawan07 wkurniawan07 moved this from Done in feature branch to Shipped to master branch in GAE Runtime Upgrade Jun 6, 2021
daongochieu2810 pushed a commit to daongochieu2810/teammates that referenced this issue Jul 5, 2021
@jianhandev @daongochieu2810
[TEAMMATES#11001] Migrate App Engine Text datastore type (TEAMMATES#1…
d182afb 
…1019)

* Replace usage of Text type from appengine datastore api with StringValue

* Use unindexed String as alternative over StringValue previously used to replace Text

* Simplify getters and setters

* Remove redundant architecture test method after deprecating use of datastore Text type
daongochieu2810 pushed a commit to daongochieu2810/teammates that referenced this issue Jul 5, 2021
@jianhandev @daongochieu2810
[TEAMMATES#11001] Handle datastore exceptions using the new Google-pr…
a72faeb 
…ovided SDK (TEAMMATES#11025)

* Remove usage of DatastoreTimeoutException from old api

* Get WebApiServlet to throw specific datastore error messages

* Replace hard-coded values with enum values of google.rpc.Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Derek-Hardy Derek-Hardy

@jianhandev jianhandev

Labels
a-Storage Database schema, Datastore-related technologies/quirks c.Task Other non-user-facing works, e.g. refactoring, adding tests
Projects
No open projects
GAE Runtime Upgrade
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wkurniawan07 @Derek-Hardy @jianhandev