Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor courses page: fix margin of copy instructors from other courses modal on mobile #12344

Closed
weiquu opened this issue Apr 5, 2023 · 4 comments · Fixed by #12389
Closed
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future

Comments

@weiquu
Copy link
Contributor

weiquu commented Apr 5, 2023

Path: Instructor pages -> Courses tab -> Edit course details -> Copy instructors from other courses

The modal that appears has a large margin on the right, which is different from the behaviour of other modals on mobile:
copy instructors modal closed

This makes it difficult to read the text in the table:
copy instructors modal open

@weiquu weiquu added a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future good first issue Easy; restricted for first-time contributors labels Apr 5, 2023
@vishalsingh2972
Copy link

@weiquu could you assign this to me if it's still open?
P.S Also new here so could you please also attach the exact folder in the repository so that I can try looking at the problem directly without getting overwhelmed by the huge code base.

@weiquu
Copy link
Contributor Author

weiquu commented Apr 5, 2023

Hi @vishalsingh2972, we don't assign issues to contributors, but feel free to submit a PR for this issue.

P.S Also new here so could you please also attach the exact folder in the repository so that I can try looking at the problem directly without getting overwhelmed by the huge code base.

I suggest that you first follow the steps here to set up the development environment, and then take a look at the development workflow. After you've done that, you can navigate to the path highlighted in the issue and find the relevant component/file by inspecting the page's elements (or any other means).

Being able to individually navigate through a larger, unfamiliar codebase is a good skill for an open-source contributor (or any software developer) to have. I hope you'll take this chance to get some experience and learn how to do so (: That being said, do reach out if you face any issues along the way

@b-walton
Copy link
Contributor

Is it ok If I take on this issue? Unless you are still working on it @vishalsingh2972

@vishalsingh2972
Copy link

Is it ok If I take on this issue? Unless you are still working on it @vishalsingh2972

Very kind of you to ask @b-walton , sure please go ahead 👍

zhaojj2209 pushed a commit that referenced this issue Apr 23, 2023
… other courses modal on mobile (#12389)

* Fixed copy instructors mobile margin

* Passed linting

* Updated solution to increase consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future
Projects
None yet
3 participants