Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header: unable to expand dropdown with keyboard commands #12530

Closed
weiquu opened this issue Jul 30, 2023 · 0 comments · Fixed by #12542
Closed

Header: unable to expand dropdown with keyboard commands #12530

weiquu opened this issue Jul 30, 2023 · 0 comments · Fixed by #12542
Labels
a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future

Comments

@weiquu
Copy link
Contributor

weiquu commented Jul 30, 2023

I'm able to tab over the dropdown buttons in the header, but pressing spacebar or enter/return doesn't expand the dropdown. This issue is present both for the "Help" dropdown as well as the user email dropdown (on the far right).

Other dropdowns are able to be expanded with either the spacebar or enter/return or both.
@weiquu weiquu added a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future labels Jul 30, 2023
@github-actions github-actions bot mentioned this issue Jul 30, 2023
Open
@domoberzin domoberzin mentioned this issue Aug 1, 2023
Merged
jasonqiu212 added a commit that referenced this issue Aug 4, 2023
@domoberzin @jasonqiu212
[#12530] Allow header dropdown to be opened with enter key (#12542)
5bc54fc 
* fix: allow dropdown to be opened with enter key

* fix: lint issues

* fix: remove tab index

* fix: remove button click color change

* fix: lint

---------

Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12530] Allow header dropdown to be opened with enter key domoberzin/teammates
1 participant
@weiquu