Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit responses: ignore outdated responses #6471

Open
damithc opened this issue Jan 27, 2017 · 4 comments
Open

Submit responses: ignore outdated responses #6471

damithc opened this issue Jan 27, 2017 · 4 comments
Labels
p.Medium Marginal impact; would like to do if time permits s.ToInvestigate The issue sounds complete but needs validation by a core team member

Comments

@damithc
Copy link
Contributor

damithc commented Jan 27, 2017

Outdated responses (see #6470) cause the submission form of affected students to have To: without student name. In the screenshot below, I've marked where a name will be missing if this situation occurs.

image

@damithc damithc added c.Bug Bug/defect report f-Submissions p.Medium Marginal impact; would like to do if time permits labels Jan 27, 2017
@damithc
Copy link
Contributor Author

damithc commented Jan 27, 2017

@kanghj I remember you did some investigation to a similar issue before. Any inputs?

@kanghj
Copy link
Member

kanghj commented Jan 27, 2017

I'll do a more thorough investigation in 1 or 2 days time, but I recall that it may happen if we failed to modify/delete responses due to a change in student's email (or if we are using a task queue for this, the task for modifying the responses hasn't executed).

@kanghj
Copy link
Member

kanghj commented Feb 1, 2017

The cascaded update to responses for editing emails and teams appears to be correct locally (other than #3404). If this issue is not a frequent occurrence, a possible cause is eventual consistency. Outdated responses will be left if the cascade failed to update all the required responses.

Anyway, we could automatically detect and hide invalid recipients on the feedback submission page as a quick fix.

Linking to #6020 since this is a duplicate

@damithc damithc changed the title Outdated responses mess up the submission form Submit responses: ignore outdated responses May 20, 2017
@damithc damithc removed the c.Bug Bug/defect report label May 20, 2017
@wkurniawan07 wkurniawan07 added this to the V7.1.0 milestone Aug 10, 2020
@xpdavid
Copy link
Contributor

xpdavid commented Aug 13, 2020

In V7:

Under QuestionSubmissionFormMode.FIXED_RECIPIENT mode, outdated responses will be ignore.

Under QuestionSubmissionFormMode.FLEXIBLE_RECIPIENT mode, outdated responses will be used and will cause submission error.

@wkurniawan07 wkurniawan07 added the s.ToInvestigate The issue sounds complete but needs validation by a core team member label Aug 16, 2020
@wkurniawan07 wkurniawan07 modified the milestones: Fault-Tolerance, V8.X.0 Aug 8, 2021
@wkurniawan07 wkurniawan07 removed this from the V8.X.0 milestone Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p.Medium Marginal impact; would like to do if time permits s.ToInvestigate The issue sounds complete but needs validation by a core team member
Projects
None yet
Development

No branches or pull requests

5 participants