Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show default picture as profile photo for student who is yet to join #9405

Closed
jacoblipech opened this issue Feb 7, 2019 · 1 comment · Fixed by #9414
Closed

Show default picture as profile photo for student who is yet to join #9405

jacoblipech opened this issue Feb 7, 2019 · 1 comment · Fixed by #9414
Labels
a-UIX User Interface, User eXperience, responsiveness

Comments

@jacoblipech
Copy link
Contributor

  • Environment: local server at V7.0.0, master branch at commit ede259e.

Steps to reproduce
Go to student search page and search for a yet to join student.

Expected behaviour
Logically, a student with yet to join tag should have a default profile picture or not clickable profile picture. It should not be the error message as shown in the current behaviour below when clicked on View Photo.
image

Actual behaviour
In V6.0 a student profile with yet to join tag generates a default picture when clicked on the View Photo.
image

Additional info
Consider showing a default picture when clicked on or disable the ability to click View Photo for yet to join students.
@jacoblipech jacoblipech added a-UIX User Interface, User eXperience, responsiveness v7-only labels Feb 7, 2019
@monmanuela
Copy link
Contributor

I'll work on this!

@monmanuela monmanuela mentioned this issue Feb 9, 2019
Merged
@wkurniawan07 wkurniawan07 changed the title Unable to load student's profile photo in search result for yet to joined students Show default picture as profile photo for student who is yet to join Feb 10, 2019
wkurniawan07 pushed a commit that referenced this issue Feb 10, 2019
@monmanuela @wkurniawan07
[#9405] Show default picture as profile photo for student who is yet …
04910f0 
…to join (#9414)
Adoby7 pushed a commit to Adoby7/teammates that referenced this issue Feb 12, 2019
@monmanuela @Adoby7
[TEAMMATES#9405] Show default picture as profile photo for student wh…
40905d8 
…o is yet to join (TEAMMATES#9414)
Adoby7 pushed a commit to Adoby7/teammates that referenced this issue Feb 12, 2019
@monmanuela @Adoby7
[TEAMMATES#9405] Show default picture as profile photo for student wh…
e4c9c2a 
…o is yet to join (TEAMMATES#9414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#9405] Show default picture as profile photo for student who is yet to join monmanuela/teammates
2 participants
@jacoblipech @monmanuela