Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor: Course Edit Details: Unable to edit/add instructor #9520

Closed
tanhengyeow opened this issue Feb 28, 2019 · 3 comments
Closed

Instructor: Course Edit Details: Unable to edit/add instructor #9520

tanhengyeow opened this issue Feb 28, 2019 · 3 comments
Labels
c.Bug Bug/defect report p.High Significant impact; would like to do in the next few releases

Comments

@tanhengyeow
Copy link
Member

Environment:
master branch

Steps to reproduce

Go to /web/instructor/courses/edit?courseid=<valid course id>

  1. First bug:
  • Edit an instructor and click Save changes. Nothing happens.
  1. Second bug:
  • Click Add New Instructor, fill in some details and click Add Instructor
  • Following error faced:
    image
@tanhengyeow tanhengyeow added p.High Significant impact; would like to do in the next few releases c.Bug Bug/defect report v7-only labels Feb 28, 2019
@wkurniawan07 wkurniawan07 mentioned this issue Feb 28, 2019
Merged
4 tasks
@wkurniawan07
Copy link
Member

@tanhengyeow I've located the regressing code change. Two-liner change. Just do it.

This was referenced Mar 1, 2019
Merged
Closed
@Gomaa
Copy link

Gomaa commented Mar 3, 2019

I followed teammates dev documentation, and my work space is just ready for work. Is it possible to get assigned to this issue?

@monmanuela
Copy link
Contributor

Hi @Gomaa , there's already an open PR to fix this issue. Feel free to look at other first timer issues to work on :)

wkurniawan07 pushed a commit that referenced this issue Mar 3, 2019
@rrtheonlyone @wkurniawan07
[#9520] Update new instructor API endpoints on frontend (#9524)
002f860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Bug Bug/defect report p.High Significant impact; would like to do in the next few releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Gomaa @wkurniawan07 @tanhengyeow @monmanuela