Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E testing to teammates pages in v7 #9536

Closed
26 of 27 tasks
jacoblipech opened this issue Mar 4, 2019 · 2 comments
Closed
26 of 27 tasks

Add E2E testing to teammates pages in v7 #9536

jacoblipech opened this issue Mar 4, 2019 · 2 comments
Labels
a-CodeQuality Code/design quality-related traits, static analysis a-Testing Testing-related traits such as efficiency, robustness, coverage c.Epic Feature/task that is worth many smaller sub-features/sub-tasks help wanted Moderate difficulty, small localized change; suitable for novice contributors
Projects
Launch of new E2E tests

Comments

@jacoblipech
Copy link
Contributor

jacoblipech commented Mar 4, 2019 •
edited by wkurniawan07

Migrate end to end tests for all the pages below from v6 to v7

  • Student Home Page
  • Student Profile Page
  • Student Course Details Page
  • Admin Home Page
  • Admin Accounts Page
  • Admin Search Page
  • Admin Sessions Page
  • Instructor Home Page
  • Instructor Course Details Page
  • Instructor Courses Page
  • Instructor Course Edit Page
  • Instructor Course Enroll Page
  • Instructor Course Student Details Page
  • Instructor Course Student Edit Page
  • Instructor Search Page (ticked by default; see division of cases)
    • Students table
    • Responses + response comments table
  • Instructor Student List Page
  • Instructor Student Records Page (ticked by default; see division of cases)
    • Student details
    • Feedback responses given/received by student
  • Instructor Session Edit Page
  • Instructor Sessions Page
  • Instructor Session Result Page
  • Session Submission Page
  • Session Result Page
  • Course Join Page
@jacoblipech jacoblipech mentioned this issue Mar 4, 2019
Merged
@wkurniawan07
Copy link
Member

While we can use the browser tests in V6 as reference, we need to significantly re-think how to structure the tests such that they are indeed E2E level. In V6 and before, there were way too many stuffs tested in the browser tests that should be tested in lower level. It does not help that our severe overuse of God mode has eroded the value of testing (now we can barely remember what to pay attention to for each HTML test file). Of course, to be fair, there are factors such as lack of supporting infrastructure.

@wkurniawan07 wkurniawan07 added c.Epic Feature/task that is worth many smaller sub-features/sub-tasks a-Testing Testing-related traits such as efficiency, robustness, coverage a-CodeQuality Code/design quality-related traits, static analysis labels Mar 5, 2019
jacoblipech added a commit that referenced this issue Mar 6, 2019
@jacoblipech
[#9536] Student home E2E test migration (#9503)
061f845 
* migrate files with “New” behind to different v6 and v7 files. Unable to remove v6 files due to strong dependency on AppPage

* migrate studentHomePageE2ETest and and update BaseE2ETestCase

* implement NewBackDoor methods to handle different calls to front end for testing

* Initialise a new BackDoorTestAction which needs further implementation to link to the specific front end urls

* uncomment out loginAdminAsInstructor to log in studentHome as Admin

* `containsExpectedPageContents` is not needed to work anymore as `getPageSource()` no longer gets the entire page content.

* remove jQueryAjaxHandler

* change the way comment out is used

* add id to front end elements to handle selenium

* add additional dependencies to compile and build

* remove unused methods

* as pageSource does not work anymore, uses another way to populate different title at each page to check accuracy of the page.

* endpoint for data bundle action

* remove unnecessary methods in NewBackDoor

* remove html verification and persistent login method, add comments to request help

* waitForPageToLoad() always load probably due to front end being generated from angular. Hence it no longer works and needs to be replaced with visibility function

* update html frontend to show title message despite error

* Implement endpoints to persist and remove data bundle

* Add NewBackDoor method to persist data bundle

* Remove duplicated classes

* Add CS suppressions for methods/variables in pageobjects package

* Add Macker rule exception

* Separate removing and persisting of data bundle

* Move old BackDoor back to teammates.test package

* Rename NewBackDoor -> BackDoor

* Remove HtmlHelper to prevent further misuse

* Add servlet to handle logging out

* update student e2e behaviour tests

* remove unused methods in migrated AppPageNew

* migrate all pages related to StudentHomeE2ETest and add New to the class such as LoginPageNew.
Also handled check style errors and import statements.

* add all the basic testing functions of StudentHomePageE2ETest and remove unnecessary methods in AppPageNew

* Remove migrated files

* fix javadoc, comments, refactor code

* remove unnecessary unused tests

* fix lint error and remove unnecessary id populated

* reorganise test json file to remove unnecessary information and fix StudentHomeE2ETest cases

* Add test accounts

* Rename AppPageNew -> AppPage

* fix javadoc for pages in e2e tests

* remove unnecessary changes and fix `kebab-case` in ids

* fix naming and logic for student home e2e tests

* refactor appPage to separate script into javascript files

* Removing the waitForPageToLoad() function as the refactored code for `waitForPageToLoad()` function causes it to timeout

* Fix waitForPageToLoad issue in home page

* Remove mentions to development server where unnecessary
@jacoblipech jacoblipech mentioned this issue Mar 13, 2019
Merged
3 tasks
jacoblipech added a commit that referenced this issue Mar 18, 2019
@jacoblipech
[#9536] Student profile page e2e test migration (#9569)
9542ad8 
* migrate relevant pages used for student profile page

* add java docs for migrated pages

* remove and migrate unnecessary images

* front end changes to allow web elements to find the correct elements

* add basic workflow of a student using the student profile page features

* additional styling issues

* revert back images stored

* remove unnecessary and unused files (html pages, EntityNotFound and StudenProfilePicturePage) from v6

* remove unnecessary method calls and refactor codes

* retrieves StudentProfileAttribute and verify profile pic url has correct picturekey value

* remove unnecessary json test cases and simplify data initialisation process

* continue to use TEST_STUDENT2_ACCOUNT as student1_account conflicts with studentHomeE2E test

* fix marven error to generate StudentProfileAttributes in another way
@jacoblipech jacoblipech mentioned this issue Mar 18, 2019
Merged
3 tasks
@wkurniawan07 wkurniawan07 mentioned this issue Mar 24, 2019
Merged
jacoblipech added a commit that referenced this issue Mar 24, 2019
@jacoblipech
[#9536] Student course details page e2e test migration (#9579)
a1c2118 
* migrate student course details page E2E test from v6 to v7

* remove unnecessary pages from for student course details page

* add studentcoursedetailspagee2eTest to testing-e2e.xml file

* refactor studentViewTeamBtn to StudentHomePage

* refactor e2e tests and fix e2e stability on travis
wkurniawan07 added a commit that referenced this issue Mar 27, 2019
@wkurniawan07
[#9536] [#9480] Add front-end, snapshot, E2E tests for admin home page (
4e5d230 
#9605)

* Add snapshot tests for admin home page

* Add AdminHomePageE2ETest

* Remove legacy admin home page UI test

* Remove dependency of existing E2E tests to real accounts

* Add admin home page front-end tests
@jacoblipech jacoblipech mentioned this issue Apr 16, 2019
Closed
9 tasks
@jtankw3 jtankw3 mentioned this issue Mar 16, 2020
Merged
wkurniawan07 pushed a commit that referenced this issue Mar 30, 2020
@jtankw3
[#9536] Admin Search Page E2E Tests (#9987)
cd18639
@jtankw3 jtankw3 mentioned this issue Apr 11, 2020
Merged
madanalogy pushed a commit that referenced this issue May 5, 2020
@jtankw3
[#9536] Fix flaky status message test in StudentProfilePage (#10016)
7e9e884
This was referenced May 6, 2020
Merged
Merged
madanalogy added a commit that referenced this issue May 27, 2020
@jtankw3 @madanalogy
[#9536] Instructor Course Enroll Page E2E Test (#10033)
fcd836b 
* Update InstructorCourseEnrollPageE2ETest

* Fix bugs and lint InstructorCourseEnrollPageE2ETest

* Fix bugs causing Travis failure

* Add backend checks and reduce rows added in test

Co-authored-by: Ahmed Bahajjaj <Ahmed_Bahajjaj@u.nus.edu>
jtankw3 added a commit that referenced this issue May 28, 2020
@jtankw3 @wkurniawan07
[#9536] Instructor Course Edit Page E2E Test (#10045)
19e7d0b 
* Update InstructorCourseEditPageE2ETest

* Fix bugs and linting

* Add some methods to BackDoor to facilitate checking datastore

* Add extra checks to InstructorCourseEditPageE2ETest to account for backend

* Some changes to InstructorCourseEditPage to reduce intermittent failing

* Add extra wait

* Remove wait from AppPage that causes timeouts

* Delete old files

* Remove wait

* Change import order

* Use existing verify datastore methods

Co-authored-by: Wilson Kurniawan <wkurniawan.92@gmail.com>
@jtankw3 jtankw3 mentioned this issue May 28, 2020
Merged
madanalogy pushed a commit that referenced this issue Jun 15, 2020
@jtankw3
[#9536] Instructor Courses Page E2E Test (#10133)
790d882 
* Add Backdoor methods to access archived course details

* Add InstructorCoursesPage

* Add InstructorCoursesPageE2ETest

* Standardize lower case for test case description

* Update snapshots

* Use system default zoneId for date string comparison

* Delete old files

* Get course statistics programmically

* Add retries for archive course verification

* Use system default timezone for deleted details

* Fix code quality issues
@jtankw3 jtankw3 mentioned this issue Jun 25, 2020
Merged
This was referenced Jul 13, 2020
Merged
Merged
madanalogy pushed a commit that referenced this issue Jul 14, 2020
@jtankw3
[#9536] Fix Student Course Detail Page E2E Test (#10310)
b72ffa6 
* Fix flaky StudentCourseDetailsPageE2ETest

* Update snapshots
madanalogy pushed a commit that referenced this issue Jul 18, 2020
@jtankw3
[#9536] Adjust wait to help flakiness (#10311)
334f3a4
This was referenced Aug 2, 2020
Merged
Merged
@wkurniawan07 wkurniawan07 added this to In progress in Launch of new E2E tests Oct 17, 2020
@wkurniawan07 wkurniawan07 mentioned this issue Oct 18, 2020
Merged
wkurniawan07 added a commit that referenced this issue Oct 20, 2020
@wkurniawan07
[#9536] Migrate remaining Admin E2E tests (#10784)
036afd3
wkurniawan07 added a commit that referenced this issue Oct 21, 2020
@wkurniawan07
[#9536] Migrate parts of instructor search/student list/records page …
ebc9627 
…E2E tests (#10796)
@jtankw3 jtankw3 mentioned this issue Oct 22, 2020
Merged
@wkurniawan07 wkurniawan07 mentioned this issue Oct 24, 2020
Merged
@jtankw3 jtankw3 mentioned this issue Oct 24, 2020
Merged
wkurniawan07 added a commit that referenced this issue Oct 25, 2020
@wkurniawan07
[#9536] Remove all code related to legacy UI tests (#10810)
573c7c1
@jtankw3 jtankw3 mentioned this issue Oct 26, 2020
Merged
@wkurniawan07 wkurniawan07 mentioned this issue Oct 26, 2020
Merged
wkurniawan07 added a commit that referenced this issue Oct 29, 2020
@wkurniawan07
[#9536] Clean up test accounts and add test data checker (#10821)
cb61d47
jtankw3 added a commit that referenced this issue Nov 1, 2020
@jtankw3
[#9536] Fix Feedback Question E2E tests problems (#10820)
309b3dd 
* Remove student key from submit page urls

* Add one reload if page is stuck loading

* Add waits to submit page object

* Add wait for feedback edit page

* Add BaseFeedbackQuestionE2ETest

* Exclude all base classes from TestNgXmlTest

* Fix lint errors
jtankw3 added a commit that referenced this issue Nov 1, 2020
@jtankw3
[#9536] Student Feedback Results Page E2E Test (#10696)
ce099e6 
* Add StudentFeedbackResultsPageE2ETest

* Add loaded question check for unregistered student

* Skip response check for contrib question in page object

* Refactor for code quality

* Use lineSeparator

* Replace statistics with hardcoded expected

* Use AssertionError instead of RuntimeException
@wkurniawan07 wkurniawan07 mentioned this issue Nov 1, 2020
Merged
wkurniawan07 added a commit that referenced this issue Nov 2, 2020
@wkurniawan07
[#9536] Implement E2E test data validity check (#10826)
0262055
@jtankw3 jtankw3 mentioned this issue Nov 2, 2020
Merged
jtankw3 added a commit that referenced this issue Nov 3, 2020
@jtankw3 @madanalogy
[#9536] Update docs for E2E testing (#10812)
e7d18b0 
* Update docs for E2E testing

* Edit e2e testing doc

* Update README

* Add abstract method testAll

* Clean up docs

* Clean up TimezoneSyncerTest

* Shift E2E running details to e2e-testing.md

* Improve document layout and wording

Co-authored-by: Ahmed Bahajjaj <Ahmed_Bahajjaj@u.nus.edu>
wkurniawan07 pushed a commit that referenced this issue Nov 11, 2020
@jtankw3
[#9536] Improve E2E for Production Server Testing (#10827)
0085799 
* Fix submit page access issues

* Fix email related issues

* Add changes to improve stability

* Run E2E in single thread for production server

* Fix timing issues

* Remove logouts

* Fix chrome preference settings

* Improve email checks

* Update E2E documetation

* Remove infinite loop in FeedbackSubmitPage

* Use getListOfUnreadEmailFromSender for getUserAuthenticated
This was referenced Nov 29, 2020
Merged
Merged
wkurniawan07 added a commit that referenced this issue Dec 5, 2020
@wkurniawan07
[#9536] Fix AdminSessionsPageE2ETest due to wrong year pattern (#10853)
af5cba1
@wkurniawan07 wkurniawan07 unpinned this issue Dec 6, 2020
wkurniawan07 pushed a commit that referenced this issue Dec 14, 2020
@jtankw3
[#9536] Instructor Feedback Results Page E2E Test (#10801)
d3470d6
wkurniawan07 added a commit that referenced this issue Dec 14, 2020
@wkurniawan07
[#9536] Enforce page object pattern via architectural check and remov…
a61aa0d 
…e unused items (#10850)
@wkurniawan07 wkurniawan07 moved this from In progress to Done in Launch of new E2E tests Dec 14, 2020
@wkurniawan07
Copy link
Member

This can be considered as done as we have sufficient E2E tests now.

@wkurniawan07 wkurniawan07 mentioned this issue Dec 30, 2020
Merged
wkurniawan07 added a commit that referenced this issue Jan 18, 2021
@wkurniawan07
[#9536] Improve E2E test stability and add test for searching respons…
d79d4fb 
…e comments (#10900)
@wkurniawan07 wkurniawan07 removed this from the V7.X.0 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-CodeQuality Code/design quality-related traits, static analysis a-Testing Testing-related traits such as efficiency, robustness, coverage c.Epic Feature/task that is worth many smaller sub-features/sub-tasks help wanted Moderate difficulty, small localized change; suitable for novice contributors
Projects
No open projects
Launch of new E2E tests
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wkurniawan07 @jacoblipech @madanalogy