Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error message for Instructor Course Details Ajax failure #9584

Closed
AyushChatto opened this issue Mar 19, 2019 · 3 comments · Fixed by #9591
Closed

Change error message for Instructor Course Details Ajax failure #9584

AyushChatto opened this issue Mar 19, 2019 · 3 comments · Fixed by #9591
Labels
good first issue Easy; restricted for first-time contributors

Comments

@AyushChatto
Copy link
Contributor

The current error message for an Ajax failure is 'Failed to load. Please reopen modal.'. Since modal is a technical term, it should not be used for anything facing the client, and must be replaced with a better error message.

  • Environment:
    v7.0
@AyushChatto AyushChatto changed the title Change error message for Change error message for Instructor Course Details Ajax failure Mar 19, 2019
@AyushChatto AyushChatto added good first issue Easy; restricted for first-time contributors t-HTML and removed t-HTML labels Mar 19, 2019
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @AyushChatto. I would like to work on this issue?

@a-deeb a-deeb mentioned this issue Mar 20, 2019
Merged
@AyushChatto
Copy link
Contributor Author

@devotion-it go for it :) Do familiarise yourself with our contributors guide :)

@ghost ghost mentioned this issue Mar 20, 2019
Closed
10 tasks
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @AyushChatto just wanted to inform you that i submitted a PR for this issue.

RonakLakhotia pushed a commit that referenced this issue Apr 9, 2019
@a-deeb @RonakLakhotia
[#9584] Change error message for Instructor Course Details Ajax failu…
0861182 
…re (#9591)

* Update instructor-course-details-page.component.html

* Update instructor-course-details-page.component.html

* Update instructor-course-details-page.component.html

* Update instructor-course-details-page.component.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy; restricted for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#9584] Change error message for Instructor Course Details Ajax failure
1 participant
@AyushChatto