Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback sessions with # or ? in their name can't be edited. #9642

Closed
ChooJeremy opened this issue Apr 3, 2019 · 7 comments · Fixed by #9925
Closed

Feedback sessions with # or ? in their name can't be edited. #9642

ChooJeremy opened this issue Apr 3, 2019 · 7 comments · Fixed by #9925
Labels
c.Bug Bug/defect report help wanted Moderate difficulty, small localized change; suitable for novice contributors

Comments

@ChooJeremy
Copy link
Contributor

Other potential characters may cause this problem as well.

  • Environment: master branch at commit 3455dda.

Steps to reproduce

  1. Login as an instructor.
  2. Create a new feedback session with # in the name (i.e. test Feedback sessions with # or ? in their name can't be edited. #9642)
  3. Click edit on the new feedback session.

Expected behaviour
The feedback session edit page loads

Actual behaviour
It doesn't load.
image

Additional info

This error occurs even after applying the fix from #9638 .
The server outputs the error log:
WARNING: UnauthorizedAccessException caught by WebApiServlet: Trying to access system using a non-existent feedback session entity
The error appears to be from the frontend not sending the character # or ? in the query (and anything after it)
@ChooJeremy ChooJeremy added c.Bug Bug/defect report f-Sessions labels Apr 3, 2019
@TheDheeraj007
Copy link

Hello! This issue looks interesting. Can I work on this issue?

@ChooJeremy
Copy link
Contributor Author

ChooJeremy commented Jun 29, 2019 •
edited

Sure, go ahead! Usually we recommend starting with a first timer issue, but since there aren't many first timer issues right now feel free to start working on this.

@dodgees
Copy link
Contributor

dodgees commented Oct 4, 2019

It looks like there hasn't been any activity on this issue. Mind if I pick it up?

@ChooJeremy
Copy link
Contributor Author

I don't mind - Go ahead :)

@hcwong
Copy link
Contributor

hcwong commented Jan 17, 2020

If this is inactive I would like to take it

@hcwong
Copy link
Contributor

hcwong commented Jan 17, 2020

It's probably the issue with URL special characters. I'm thinking of decoding/encoding the strings properly and also preventing future session names from having such characters.

@xpdavid xpdavid added the help wanted Moderate difficulty, small localized change; suitable for novice contributors label Jan 17, 2020
@ChooJeremy
Copy link
Contributor Author

Looks inactive - go ahead.

@hcwong hcwong mentioned this issue Jan 20, 2020
Merged
wkurniawan07 pushed a commit that referenced this issue Feb 28, 2020
@hcwong
[#9642] Feedback sessions with # or ? in their name can't be edited. (#…
3d63185 
…9925)
tiuweehan added a commit to tiuweehan/teammates that referenced this issue Feb 28, 2020
@tiuweehan
Merge branch 'master' into 9940-standardize-instructor-api-endpoints
addd29d 
* master:
  [TEAMMATES#9382] Add MasqueradeModeService Tests (TEAMMATES#9955)
  [TEAMMATES#9302] Support rich text for MCQ option text (TEAMMATES#9944)
  [TEAMMATES#9642] Feedback sessions with # or ? in their name can't be edited. (TEAMMATES#9925)
  [TEAMMATES#9970] Fix failing Travis build (TEAMMATES#9971)
@odinn1984 odinn1984 mentioned this issue Jul 8, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 9, 2022
Open
@hoanglan21 hoanglan21 mentioned this issue Jul 9, 2022
Open
@hoanglan21 hoanglan21 mentioned this issue Oct 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Bug Bug/defect report help wanted Moderate difficulty, small localized change; suitable for novice contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#9642] Feedback sessions with # or ? in their name can't be edited. hcwong/teammates
5 participants
@ChooJeremy @dodgees @xpdavid @TheDheeraj007 @hcwong