Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor: Course Page: Some navbar buttons are not responsive after snackbar is shown #9662

Closed
tanhengyeow opened this issue Apr 11, 2019 · 3 comments · Fixed by #9712
Closed
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report p.Medium Marginal impact; would like to do if time permits

Comments

@tanhengyeow
Copy link
Member

Environment:
master branch

Steps to reproduce

  1. Go to the instructor course page
  2. Add a new valid course. The green snackbar would show.
  3. Click on the Sessions and Students tab when the snackbar is present.

Expected behavior
The respective page should be accessible.

Actual behaviour
The Sessions and Students tabs are not clickable.

Additional info
Same behavior in instructor sessions page but the Courses tab is also not clickable.

Error snackbar shows different behavior.

@tanhengyeow tanhengyeow added a-UIX User Interface, User eXperience, responsiveness p.Medium Marginal impact; would like to do if time permits c.Bug Bug/defect report v7-only labels Apr 11, 2019
@monmanuela
Copy link
Contributor

Tested this, I can reproduce the bug. the issue seems to be because of

.snackbar {
max-width: 100% !important;
margin-top: 60px !important;
}

The margin-top causes the tabs that are vertically above the snackbar to not be clickable. Also, error snackbars seem to show different behaviors only because the error snackbars are relatively shorter, so there are no tabs vertically above them. Error snackbars with longer messages have the same bug.

@Barbado2017
Copy link
Contributor

Barbado2017 commented Apr 16, 2019

Can I take this issue?
EDIT: Never mind, I am no longer working on this issue.

@erjillsison
Copy link
Contributor

erjillsison commented May 23, 2019

The margin-top doesn't seem to cause the issue. The problem's likely inherited from the MatSnackBar itself. Possible solution is to put the navbar on top of the snackbar by setting its z-index higher.

xpdavid added a commit to erjillsison/teammates that referenced this issue Jun 6, 2019
…-navbar-buttons-are-not-responsive-after-snackbar-is-shown
xpdavid pushed a commit that referenced this issue Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report p.Medium Marginal impact; would like to do if time permits
Projects
None yet
4 participants