Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise look of feedback session details card #9667

Closed
amrut-prabhu opened this issue Apr 12, 2019 · 4 comments · Fixed by #9825
Closed

Standardise look of feedback session details card #9667

amrut-prabhu opened this issue Apr 12, 2019 · 4 comments · Fixed by #9825
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors

Comments

@amrut-prabhu
Copy link
Contributor

  • Environment: master branch at commit a1c2118

Steps to reproduce

  1. Go to a feedback session submission page (web/student/sessions/submission?courseid=test.exa-demo&fsname=Session%20with%20different%20question%20types)
  2. Go to a feedback session results page (web/student/sessions/result?courseid=test.exa-demo&fsname=Session%20with%20different%20question%20types)

Expected behaviour
The card describing the session should look the same on both pages

Actual behaviour
The descriptions (course id, session, opening time ...) do not have the same styling

Submit page:
2019-04-12_10h49_21

Results page:
2019-04-12_10h49_16

@amrut-prabhu amrut-prabhu added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors v7-only labels Apr 12, 2019
@PanagiotisBatsikouras
Copy link

Hello I want to be a new contributor to your project because I find it very interesting. Can I take up that issue? However because I am mainly a Java developer, is this issue Java related or it has to do with html?

@amrut-prabhu
Copy link
Contributor Author

Hi @PanagiotisBatsikouras , thank you for your interest in TEAMMATES :)

Since this is a a frontend issue (note that it's labelled a-UIX), this issue is html related (albeit, pretty simple). For a Java related first timer issue, you can try working on issue#9252 to get used to our contributing process. After that, you can look for issues labelled d.Contributors.

Hope that helps!

@hppranaav
Copy link
Contributor

Hi, my name is Pranaav and I would like to work on this fix. Could you please tell me where the feedback sessions results page is being generated as i am not able to locate it.
Thank you.

@adrianbrenton
Copy link

Hi, can I work on this issue please? It's my first time contributing to this project!

xpdavid pushed a commit that referenced this issue Aug 27, 2019
* Standardise look of feedback session details card #9667

* #9667- part 2 - Removed commented block

* 9667 - Lint changes to adjust empty line spacing in code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors
Projects
None yet
4 participants