-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#10885] Numerical scale question table is not responsive to different browser size #10896
Conversation
Hi @yzia2000, these parts of your pull request do not appear to follow our contributing guidelines:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way could be adding overflow: scroll
attribute under .main-body
selector. But this solution seems to work well.
Suggest to adjust down max-width
a bit to keep the sidebar when room permits.
@@ -19,11 +19,15 @@ | |||
padding-bottom: 5px; | |||
} | |||
|
|||
@media (max-width: 480px) { | |||
@media (max-width: 1500px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we can reduce some max-width
here so that sidebar does not disappear too early. Maybe try out somewhere 600-800px.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Lemme try. I chose this number because having a lower number makes the sidebar appear over the tables.
Sorry I was busy yesterday and today. Let me submit a commit that can potentially solve this issue. |
Closed due to inactivity. |
Fixes #10885
PR Checklist
Ensure that you have:
master
andrelease
./gradlew lint
andnpm run lint
Outline of Solution
Updated media query in css file and changed main container width to 100% on browser width reduction.