Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10885] Numerical scale question table is not responsive to different browser size #10896

Closed
wants to merge 4 commits into from

Conversation

yzia2000
Copy link

@yzia2000 yzia2000 commented Dec 26, 2020

Fixes #10885

PR Checklist

Ensure that you have:

  • Read and understood our PR guideline: https://github.com/TEAMMATES/teammates/blob/master/docs/process.md#step-4-submit-a-pr
    • Added the issue number to the "Fixes" keyword above
    • Titled the PR as specified in the abovementioned document
  • Made your changes on a branch other than master and release
  • Gone through all the changes in this PR and ensured that:
    • They addressed one (and only one) issue
    • No unintended changes were made
  • Run and passed static analysis: ./gradlew lint and npm run lint
  • Added/updated tests, if changes in functionality were involved
  • Added/updated documentation to public APIs (classes, methods, variables), if applicable

Outline of Solution

Updated media query in css file and changed main container width to 100% on browser width reduction.

fix

@teammates-bot
Copy link

Hi @yzia2000, these parts of your pull request do not appear to follow our contributing guidelines:

  1. PR Description
    • Issue Reference (#<issue-number>) missing.

@madanalogy madanalogy added the s.ToReview The PR is waiting for review(s) label Dec 27, 2020
Copy link
Contributor

@ccyccyccy ccyccyccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccyccyccy ccyccyccy added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Jan 1, 2021
Copy link
Contributor

@ChooJeremy ChooJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChooJeremy ChooJeremy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 1, 2021
Copy link
Contributor

@Derek-Hardy Derek-Hardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way could be adding overflow: scroll attribute under .main-body selector. But this solution seems to work well.

Suggest to adjust down max-width a bit to keep the sidebar when room permits.

@@ -19,11 +19,15 @@
padding-bottom: 5px;
}

@media (max-width: 480px) {
@media (max-width: 1500px) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we can reduce some max-width here so that sidebar does not disappear too early. Maybe try out somewhere 600-800px.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Lemme try. I chose this number because having a lower number makes the sidebar appear over the tables.

@Derek-Hardy Derek-Hardy added s.Ongoing The PR is being worked on by the author(s) and removed s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging labels Jan 15, 2021
@Derek-Hardy
Copy link
Contributor

@yzia2000 Right, there is still a glitch persists.

With your current solution at @media max-width 800px:

ezgif-3-49c615f139d9

This is not an intended behaviour.

So putting limits on .main-body is probably the right direction to think about. I tried out adding overflow: scroll that gives a good result.

@yzia2000
Copy link
Author

@yzia2000 Right, there is still a glitch persists.

With your current solution at @media max-width 800px:

ezgif-3-49c615f139d9

This is not an intended behaviour.

So putting limits on .main-body is probably the right direction to think about. I tried out adding overflow: scroll that gives a good result.

Sorry I was busy yesterday and today. Let me submit a commit that can potentially solve this issue.

@Derek-Hardy
Copy link
Contributor

Closed due to inactivity.

@Derek-Hardy Derek-Hardy closed this Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numerical scale question table is not responsive to different browser size
6 participants