-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#10922] Added top padding to Add All Instructors button #10923
[#10922] Added top padding to Add All Instructors button #10923
Conversation
There are failures on snapshot test suites because your solution has modified HTML elements in Remember to update snapshots before submission. Commonly we do If unfamiliar, you can refer to the documentation or Jest official website. |
src/web/app/pages-admin/admin-home-page/admin-home-page.component.html
Outdated
Show resolved
Hide resolved
I have removed div with 'top-padded' class, added class 'top-padded' to 'add-all-instructors' button and updated snapshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #10922
PR Checklist
Ensure that you have:
Read and understood our PR guideline: https://github.com/TEAMMATES/teammates/blob/master/docs/process.md#step-4-submit-a-pr
Made your changes on a branch other than
master
andrelease
Gone through all the changes in this PR and ensured that:
Run and passed static analysis:
./gradlew lint
andnpm run lint
Added/updated tests, if changes in functionality were involved
Added/updated documentation to public APIs (classes, methods, variables), if applicable
Outline of Solution
Surrounded 'Add All Instructors' button with div containing class="top-padded" in /teammates/src/web/app/pages-admin/admin-home-page/admin-home-page.component.html
Changed top padding of 'Add All Instructors' button form this -
To this -