Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10920] Add front-end tests for student home page component #10925

Merged
merged 9 commits into from
Feb 9, 2021
Merged

[#10920] Add front-end tests for student home page component #10925

merged 9 commits into from
Feb 9, 2021

Conversation

Derek-Hardy
Copy link
Contributor

@Derek-Hardy Derek-Hardy commented Jan 19, 2021 •
edited
Loading

Part of #10920

Outline of Solution

  1. add snapshot tests for single/multiple courses with or without feedback session ✅
  2. add tests on sort-by Course ID and Course Name ✅
  3. add router tests for View Responses (start / edit are the same) and View Team ✅
  4. add test on disabled button with corresponding submission status ✅

@Derek-Hardy Derek-Hardy added the s.Ongoing The PR is being worked on by the author(s) label Jan 19, 2021
@Derek-Hardy Derek-Hardy added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Jan 20, 2021
@Derek-Hardy Derek-Hardy marked this pull request as ready for review January 20, 2021 14:49
@Derek-Hardy Derek-Hardy added s.Ongoing The PR is being worked on by the author(s) s.ToReview The PR is waiting for review(s) and removed s.ToReview The PR is waiting for review(s) s.Ongoing The PR is being worked on by the author(s) labels Jan 23, 2021
@Derek-Hardy Derek-Hardy reopened this Jan 23, 2021
hcwong
hcwong approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@hcwong hcwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@Derek-Hardy Derek-Hardy added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Feb 8, 2021
tiuweehan
tiuweehan approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@tiuweehan tiuweehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@madanalogy madanalogy removed the request for review from ccyccyccy February 9, 2021 02:40
@madanalogy madanalogy removed their request for review February 9, 2021 02:40
@madanalogy madanalogy added c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Feb 9, 2021
@madanalogy madanalogy added this to the V7.10.0 milestone Feb 9, 2021
@Derek-Hardy Derek-Hardy merged commit 5621286 into TEAMMATES:master Feb 9, 2021
@madanalogy madanalogy added c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed c.Feature User-facing feature; can be new feature or enhancement to existing feature labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcwong hcwong hcwong approved these changes

@tiuweehan tiuweehan tiuweehan approved these changes

Assignees

@hcwong hcwong

@tiuweehan tiuweehan

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Derek-Hardy @hcwong @tiuweehan @madanalogy