Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10920] Add frontend test for user join page component #10942

Merged
merged 3 commits into from
Feb 8, 2021
Merged

[#10920] Add frontend test for user join page component #10942

merged 3 commits into from
Feb 8, 2021

Conversation

t-cheepeng
Copy link
Contributor

Part of #10920

Outline of Solution

  • Added snapshot tests
  • Added tests for joinCourse and ngOnInit

@t-cheepeng t-cheepeng added the s.ToReview The PR is waiting for review(s) label Jan 30, 2021
@teammates-bot
Copy link

Hi @t-cheepeng, these parts of your pull request do not appear to follow our contributing guidelines:

  1. PR Title
    • Issue Reference (#<issue-number>) missing.

@t-cheepeng t-cheepeng changed the title Add test for user join page [#10920] Add test for user join page Jan 30, 2021
@t-cheepeng t-cheepeng changed the title [#10920] Add test for user join page [#10920] Add frontend test for user join page component Jan 30, 2021
ccyccyccy
ccyccyccy approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@ccyccyccy ccyccyccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ChooJeremy
ChooJeremy approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@ChooJeremy ChooJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rrtheonlyone rrtheonlyone added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Feb 7, 2021
@madanalogy madanalogy added this to the V7.10.0 milestone Feb 8, 2021
@madanalogy madanalogy added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Feb 8, 2021
@madanalogy madanalogy merged commit 7028ec9 into TEAMMATES:master Feb 8, 2021
@madanalogy madanalogy added c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed c.Feature User-facing feature; can be new feature or enhancement to existing feature labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChooJeremy ChooJeremy ChooJeremy approved these changes

@ccyccyccy ccyccyccy ccyccyccy approved these changes

Assignees

@ChooJeremy ChooJeremy

@ccyccyccy ccyccyccy

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.10.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@t-cheepeng @teammates-bot @ChooJeremy @ccyccyccy @rrtheonlyone @madanalogy @Derek-Hardy