[#10988] Fix encoding issue in Task Queue #10989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madanalogy
approved these changes
Feb 28, 2021
wkurniawan07
approved these changes
Mar 1, 2021
wkurniawan07
added
s.ToMerge
|
@madanalogy I would like to deploy this soon. Can we do a release? |
|
Yeap okay I'll release the next version tomorrow morning, should be up and ready by 11am |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10988
Seems there is an encoding issue with task queue when dealing with multibyte characters . This causes feedback session to be null.
e.g.
evaluación-testbecomesevaluación-testWe fix this by updating the headers to specify the encoding type of the body before adding to the Task Queue.