Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10974] Fix log compilation cron job #10990

Merged
merged 2 commits into from
Mar 2, 2021
Merged

[#10974] Fix log compilation cron job #10990

merged 2 commits into from
Mar 2, 2021

Conversation

madanalogy
Copy link
Contributor

Fixes #10974

@madanalogy madanalogy added the s.ToReview The PR is waiting for review(s) label Mar 1, 2021
@madanalogy madanalogy changed the title [#10974] Fix NPE in EmailGenerator.generateFeedbackSessionReminderEmails [#10974] Fix log compilation cron job Mar 1, 2021
@madanalogy madanalogy requested review from wkurniawan07 and removed request for wkurniawan07 March 1, 2021 14:09
@madanalogy madanalogy added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Mar 1, 2021
@madanalogy madanalogy added this to the V7.11.0 milestone Mar 1, 2021
@madanalogy madanalogy added the c.Bug Bug/defect report label Mar 1, 2021
wkurniawan07
wkurniawan07 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 1, 2021
@madanalogy madanalogy merged commit b63c556 into TEAMMATES:master Mar 2, 2021
@madanalogy madanalogy deleted the 10974 branch March 2, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

@rrtheonlyone rrtheonlyone rrtheonlyone approved these changes

Assignees

@wkurniawan07 wkurniawan07

@rrtheonlyone rrtheonlyone

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.11.0
Development

Successfully merging this pull request may close these issues.

NPE from scheduleFeedbackSessionPublishedEmail
3 participants
@madanalogy @wkurniawan07 @rrtheonlyone