Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10950] Refactor getting of error log entries #11050

Merged
merged 1 commit into from
Mar 22, 2021
Merged

[#10950] Refactor getting of error log entries #11050

merged 1 commit into from
Mar 22, 2021

Conversation

halfwhole
Copy link
Contributor

Part of #10950

  • Simple refactoring, no change in the overall functionality of the cloud logging service
  • Shifted searching of logs in getRecentErrorLogs to getLogEntries, left TODOs as they are

@halfwhole halfwhole added the s.ToReview The PR is waiting for review(s) label Mar 22, 2021
t-cheepeng
t-cheepeng approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@t-cheepeng t-cheepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-cheepeng t-cheepeng added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Mar 22, 2021
@madanalogy
Copy link
Contributor

madanalogy commented Mar 22, 2021 •
edited

Please don't include commits from master branch in your PR, if any changes need to be incorporated you should rebase the feature branch with master. I just did the rebase for you, clean up your commits then re-request for a review

@madanalogy madanalogy removed their request for review March 22, 2021 10:14
@halfwhole halfwhole force-pushed the 10950-refactor-cloud-logging branch from 0e5913d to 3db999b Compare March 22, 2021 10:36
@halfwhole
Copy link
Contributor Author

Yep that was my mistake, rebased the commit off the audit-logs branch

@madanalogy madanalogy requested review from wkurniawan07 and removed request for wkurniawan07 March 22, 2021 11:28
@madanalogy madanalogy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 22, 2021
@madanalogy madanalogy added this to In progress in Audit Logs for Instructors via automation Mar 22, 2021
@madanalogy madanalogy merged commit fcb84d9 into TEAMMATES:audit-logs Mar 22, 2021
Audit Logs for Instructors automation moved this from In progress to Done Mar 22, 2021
halfwhole added a commit that referenced this pull request Mar 30, 2021
@halfwhole
[#10950] Refactor getting of error log entries (#11050)
280317b
wkurniawan07 pushed a commit that referenced this pull request Mar 30, 2021
@halfwhole @wkurniawan07
[#10950] Refactor getting of error log entries (#11050)
1696110
madanalogy pushed a commit that referenced this pull request Apr 5, 2021
@halfwhole @madanalogy
[#10950] Refactor getting of error log entries (#11050)
671ed92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-cheepeng t-cheepeng t-cheepeng approved these changes

@madanalogy madanalogy madanalogy approved these changes

@AdithyaNarayan AdithyaNarayan Awaiting requested review from AdithyaNarayan

@ChooJeremy ChooJeremy Awaiting requested review from ChooJeremy

@rrtheonlyone rrtheonlyone Awaiting requested review from rrtheonlyone

Assignees

@t-cheepeng t-cheepeng

@madanalogy madanalogy

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
No open projects
Audit Logs for Instructors
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@halfwhole @madanalogy @t-cheepeng