[#11030] Batch download for session-table component #11066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daongochieu2810
requested changes
Mar 27, 2021
src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.ts
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-session-base-page.component.ts
Outdated
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-session-base-page.component.ts
Outdated
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-session-base-page.component.ts
Outdated
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-session-base-page.component.ts
Outdated
Show resolved
Hide resolved
.../app/pages-instructor/instructor-session-edit-page/instructor-session-edit-page.component.ts
Show resolved
Hide resolved
|
Thanks for reviewing! I have made the suggested changes except for the ones that are still marked as unresolved. |
moziliar
reviewed
Mar 28, 2021
teikjun
added
s.FinalReview
hcwong
approved these changes
Apr 6, 2021
teikjun
added
s.ToMerge
madanalogy
added
the
c.Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11030
Outline of Solution
In
instructor-session-base-page.component.ts:feedbackQuestionIdfor the relevant session on demand (i.e. when user clicks the "Download Results" button of the corresponding row in the session-table component)feedbackQuestionId.The changes to the UI can be viewed in an instructor's "Home" tab and "Session" tab - these are the only remaining pages that contain the "Download Results" button. The "Download Results" button on these two pages now have the same behavior as that of
instructor-session-result-page.