Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11102] Add student email to dropdown in audit logs #11113

Merged
merged 2 commits into from
May 3, 2021
Merged

[#11102] Add student email to dropdown in audit logs #11113

merged 2 commits into from
May 3, 2021

Conversation

halfwhole
Copy link
Contributor

Fixes #11102

teammates-audit-logs-8

Outline of Solution

  • Expanded the size of the student dropdown to accommodate longer text
  • Changed the student dropdown to have a value based on the student's email rather than name, given that student names may not be unique

May have potential conflicts with #11101

@halfwhole halfwhole added the s.ToReview The PR is waiting for review(s) label Apr 23, 2021
@halfwhole halfwhole added this to In progress in Audit Logs for Instructors via automation Apr 23, 2021
t-cheepeng
t-cheepeng approved these changes Apr 24, 2021
View reviewed changes
Copy link
Contributor

@t-cheepeng t-cheepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-cheepeng t-cheepeng added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Apr 24, 2021
AdithyaNarayan
AdithyaNarayan approved these changes Apr 24, 2021
View reviewed changes
Copy link
Contributor

@AdithyaNarayan AdithyaNarayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madanalogy madanalogy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels May 2, 2021
@madanalogy madanalogy added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label May 2, 2021
@madanalogy madanalogy added this to the V7.16.0 milestone May 2, 2021
@madanalogy madanalogy merged commit 6998efb into TEAMMATES:master May 3, 2021
Audit Logs for Instructors automation moved this from In progress to Done May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChooJeremy ChooJeremy ChooJeremy approved these changes

@AdithyaNarayan AdithyaNarayan AdithyaNarayan approved these changes

@t-cheepeng t-cheepeng t-cheepeng approved these changes

Assignees

@ChooJeremy ChooJeremy

@AdithyaNarayan AdithyaNarayan

@t-cheepeng t-cheepeng

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
No open projects
Audit Logs for Instructors
Done
Milestone
V7.16.0
Development

Successfully merging this pull request may close these issues.

Audit logs: Show both student name and email
5 participants
@halfwhole @ChooJeremy @AdithyaNarayan @t-cheepeng @madanalogy