Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11356] Support viewing only responses to/from themselves for instructors #11399

Merged
merged 3 commits into from
Oct 18, 2021
Merged

[#11356] Support viewing only responses to/from themselves for instructors #11399

merged 3 commits into from
Oct 18, 2021

Conversation

wkurniawan07
Copy link
Member

@wkurniawan07 wkurniawan07 commented Aug 29, 2021 •
edited
Loading

Fixes #11356

  • Repurposed /web/instructor/sessions/result URL to show individual responses (i.e. given/received by the user) only.
  • For the page that shows the course-wide responses, a new URL /web/instructor/sessions/report is used.
  • Link is added such that instructor user can freely move between the two pages.
  • New E2E test case for the instructor individual result page is added.

Notable UI changes:
Screenshot 2021-10-14 at 7 58 55 AM
Screenshot 2021-10-14 at 8 00 35 AM
Screenshot 2021-10-14 at 8 00 49 AM

@wkurniawan07 wkurniawan07 marked this pull request as ready for review September 1, 2021 04:33
@damithc
Copy link
Contributor

damithc commented Sep 1, 2021

@wkurniawan07 as our current users are used to view results to mean course-wide results, perhaps we can give parenthesis for both options in the dropdown, or only for the new option i.e., view results (received by me)?
Would there be a way to reset a link if an instructor shared a result link by mistake?
results you submitted or received -> responses you submitted or received?

@wkurniawan07
Copy link
Member Author

Would there be a way to reset a link if an instructor shared a result link by mistake?

This is a non-existent problem. The result link has no personal identifier.

@damithc
Copy link
Contributor

damithc commented Sep 1, 2021

This is a non-existent problem. The result link has no personal identifier.

Ah, right. I confused this with another feature (i.e., allowing non-registered instructors to see results)

@wkurniawan07
Copy link
Member Author

wkurniawan07 commented Sep 4, 2021 •
edited
Loading

Would there be a way to reset a link if an instructor shared a result link by mistake?

Tangentially related, but there's currently no way for this even for students. While the regenerate links feature did just that, it is advertised for lost links, not leaked links.

Edit: wrong information. The feature did exist for admin's use, and is separate from "regenerate links" feature which only lists down the links but does not change the key.

@damithc
Copy link
Contributor

damithc commented Sep 4, 2021

Tangentially related, but there's currently no way for this even for students. While the regenerate links feature did just that, it is advertised for lost links, not leaked links.

@wkurniawan07 Are you referring to the resend link feature? Yes, that one is for recovering lost links. But there is an admin feature to regenerate links for a student (although I can't remember using that feature recently). IIRC, it invalidates the previous link and creates a new one.

@madanalogy madanalogy added the s.Ongoing The PR is being worked on by the author(s) label Sep 13, 2021
@wkurniawan07 wkurniawan07 force-pushed the session-report-page branch 2 times, most recently from bc1c308 to d9011c0 Compare September 24, 2021 17:43
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@wkurniawan07 wkurniawan07 added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Oct 17, 2021
@wkurniawan07 wkurniawan07 requested review from t-cheepeng, halfwhole and damithc and removed request for damithc and halfwhole October 17, 2021 14:33
damithc
damithc approved these changes Oct 17, 2021
View reviewed changes
Copy link
Contributor

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the UI changes.

t-cheepeng
t-cheepeng approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@t-cheepeng t-cheepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Feature User-facing feature; can be new feature or enhancement to existing feature and removed s.ToReview The PR is waiting for review(s) labels Oct 18, 2021
@wkurniawan07 wkurniawan07 added this to the V8.3.0 milestone Oct 18, 2021
@wkurniawan07 wkurniawan07 merged commit 492d28e into TEAMMATES:master Oct 18, 2021
@wkurniawan07 wkurniawan07 deleted the session-report-page branch October 18, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damithc damithc damithc approved these changes

@t-cheepeng t-cheepeng t-cheepeng approved these changes

Assignees

@t-cheepeng t-cheepeng

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.3.0
Development

Successfully merging this pull request may close these issues.

Support viewing only responses to/from themselves for instructors
5 participants
@wkurniawan07 @damithc @nusoss-bot @t-cheepeng @madanalogy