Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11235] Instructor audit logs: ensure end date is not before start date #11538

Merged
merged 6 commits into from
Feb 1, 2022
Merged

[#11235] Instructor audit logs: ensure end date is not before start date #11538

merged 6 commits into from
Feb 1, 2022

Conversation

sshamouilian
Copy link
Contributor

Fixes #11235
ready for review

@jianhandev jianhandev added the s.ToReview The PR is waiting for review(s) label Jan 22, 2022
t-cheepeng
t-cheepeng approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@t-cheepeng t-cheepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-cheepeng t-cheepeng added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Jan 31, 2022
@madanalogy madanalogy added this to the V8.7.0 milestone Jan 31, 2022
@madanalogy madanalogy added the c.Bug Bug/defect report label Jan 31, 2022
@ypinhsuan ypinhsuan mentioned this pull request Feb 1, 2022
Closed
@madanalogy madanalogy merged commit 2a049b9 into TEAMMATES:master Feb 1, 2022
FergusMok pushed a commit to ziqing26/teammates that referenced this pull request Feb 5, 2022
@sshamouilian @madanalogy @FergusMok
[TEAMMATES#11235] Instructor audit logs: ensure end date is not befor…
f1af0ef 
…e start date (TEAMMATES#11538)

* Fix infinite loop for login (TEAMMATES#11530)

* [TEAMMATES#11235] prevent start date from being set before end date

* removed dplicate code

Co-authored-by: Ahmed Bahajjaj <42177597+madanalogy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-cheepeng t-cheepeng t-cheepeng approved these changes

@daongochieu2810 daongochieu2810 daongochieu2810 approved these changes

Assignees

@t-cheepeng t-cheepeng

@daongochieu2810 daongochieu2810

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.7.0
Development

Successfully merging this pull request may close these issues.

Instructor audit logs: ensure end date is not before start date
7 participants
@sshamouilian @t-cheepeng @daongochieu2810 @madanalogy @jianhandev @ziqing26 @moziliar